Skip to content

Skip tests failed due to deprecated instance type #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

Skip tests failed due to deprecated instance type #5097

merged 1 commit into from
Mar 24, 2025

Conversation

pintaoz-aws
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pintaoz-aws pintaoz-aws requested a review from a team as a code owner March 21, 2025 22:22
@pintaoz-aws pintaoz-aws requested a review from chad119 March 21, 2025 22:22
nargokul
nargokul reviewed Mar 21, 2025
View reviewed changes
tests/integ/sagemaker/serve/test_serve_model_builder_gpu.py
Comment on lines +99 to +100
if kwargs["instance_type"] == "ml.p2.xlarge":
pytest.skip("Instance type ml.p2.xlarge has been deprecated")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not call this at all from the test ?

Why do we need this additional line for a deprecated instance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the instance type could be ml.p3, which is not deprecated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a list somewhere we can remove the usage of ml.p2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No there isn't

@pintaoz-aws pintaoz-aws requested a review from nargokul March 21, 2025 23:15
@pintaoz-aws pintaoz-aws merged commit a550164 into aws:master Mar 24, 2025
13 of 14 checks passed
mollyheamazon pushed a commit to mollyheamazon/sagemaker-python-sdk that referenced this pull request Apr 8, 2025
@pintaoz-aws @mollyheamazon
Skip tests failed due to deprecated instance type (aws#5097)
1315be4 
Co-authored-by: pintaoz <pintaoz@amazon.com>
mollyheamazon pushed a commit that referenced this pull request Apr 21, 2025
@pintaoz-aws @mollyheamazon
Skip tests failed due to deprecated instance type (#5097)
1f5594c 
Co-authored-by: pintaoz <pintaoz@amazon.com>
benieric added a commit that referenced this pull request May 3, 2025
@rsareddy0329 @rohangujarathi
@Narrohag @Julfried @sagemaker-bot @nargokul @bencrabtree @rrrkharse @IshaChid76 @cj-zhang @pintaoz-aws @keshav-chandak @benieric @brunopistone @evakravi @viclzhu
Add sagemaker_utils module (#1667)
6a4e165 
* prepare release v2.241.0

* update development version to v2.241.1.dev0

* pipeline definition function doc update (#5074)

Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>

* feat: add integ tests for training JumpStart models in private hub (#5076)

* feat: add integ tests for training JumpStart models in private hub

* fixed formatting

* remove unused imports

* fix unused imports

* fix unit test failure and fix bug around versioning

* fix formatting

* fix unit tests

* fix model_uri usage issue

* fix some formatting

* separate private hub setup code

* add try catch block

* fix flake8 issue so except clause is not bare

* black formatting

* fix: resolve infinite loop in _find_config on Windows systems (#4970)

* fix: resolve Windows path handling in _find_config

* Replace Path.match("/") with Path.anchor comparison
* Fix infinite loop in _studio.py path traversal

* test: Add tests for the new root path exploration

* Fix formatting style

* Fixed line to long

* Fix docstyle by running black manually

* Fix testcase with \\ when running on non-windows machines

* Fix formatting style

* cleanup unused import

* change: update image_uri_configs  03-11-2025 07:18:09 PST

* Fixing Pytorch training python version in tests (#5084)

* Fixing Pytorch training python version in tests

* Updating Inference test handling

* remove s3 output location requirement from hub class init (#5081)

* remove s3 output location requirement from hub class init

* fix integ test hub

* lint

* fix test

---------

Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>

* fix: Prevent RunContext overlap between test_run tests (#5083)

Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>

* Torch upgrade (#5086)

* Fix Flake8 Violations

* UPDATE PYTORCH VERSION TO ADDRESS SECURITY RISK

**Description**

Currently used Pytorch version has a possible vulnerability .

Internal - https://tiny.amazon.com/p5i4jla1

**Testing Done**

Unit and Integration tests in the CodeBuild

* REvert CPU Versions

* Test Fix

* Codestyle fixes

* debug attempt

* Fixes

* Fix

* Fix

* prepare release v2.242.0

* update development version to v2.242.1.dev0

* add new regions to JUMPSTART_LAUNCHED_REGIONS (#5089)

Co-authored-by: isha chidrawar <ishachid@amazon.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>

* ADD Documentation to ReadtheDocs for Upgrading torch versions (#5090)

* ADD Documentation to ReadtheDocs for Upgrading torch versions

**Description**

**Testing Done**
Only documentation updates

* Fix for Codestyle

* Remove unused import

* Flake8 Fix

* CodeStyle Fixes

* feature: Enabled update_endpoint through model_builder (#5085)

* feature: Enabled update_endpoint through model_builder

* fix: fix unit test, black-check, pylint errors

* fix: fix black-check, pylint errors

---------

Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com>

* fix: factor in set instance type when building JumpStart models in ModelBuilder. (#5093)

* Remove main function entrypoint in ModelBuilder dependency manager.

* Remove main function entrypoint in ModelBuilder dependency manager.

* fix: factor in set instance type when building JumpStart models in ModelBuilder.

* Remove default instance type from ModelBuilder.

* Restore default instance type. Tweak integ test.

---------

Co-authored-by: Joseph Zhang <cjz@amazon.com>

* change: update image_uri_configs  03-21-2025 07:17:55 PST

* Skip tests failed due to deprecated instance type (#5097)

Co-authored-by: pintaoz <pintaoz@amazon.com>

* Feat: Added support for returing most recently created approved model package in a group (#5092)

Co-authored-by: Keshav Chandak <chakesh@amazon.com>

* change: update image_uri_configs  03-25-2025 07:18:13 PST

* chore: fix integ tests to use latest version of model (#5104)

* change: update image_uri_configs  03-26-2025 07:18:16 PST

* Update Jinja version (#5101)

* Aligned disable_output_compression for @Remote with Estimator (#5094)

* Update transformers version (#5102)

* fix: use temp file in unit tests (#5106)

* fix: fix flaky spark processor integ (#5109)

* fix: fix flaky spark processor integ

* format

* fix: fix flaky clarify model monitor test (#5107)

* chore: move jumpstart region definitions to json file (#5095)

* chore: move jumpstart region definitions to json file

* chore: address formatting issues

* fix: neo regions not ga in 5 regions

* chore: make variable private

---------

Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>

* change: Update for PT 2.5.1, SMP 2.8.0 (#5071)

* Added the config utils - centralized module for managing config file utils

* Add image_uris to sagemaker utils

* Updated python version

* Added other common utils in pysdk to this centralized module

* Test Intelligent Defaults with new utils module

---------

Co-authored-by: ci <ci>
Co-authored-by: Rohan Gujarathi <gujarathi.rohan@gmail.com>
Co-authored-by: Rohan Gujarathi <gujrohan@amazon.com>
Co-authored-by: Rohan Narayan <narrohag@amazon.com>
Co-authored-by: Julian Grimm <51880314+Julfried@users.noreply.github.com>
Co-authored-by: sagemaker-bot <sagemaker-bot@amazon.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
Co-authored-by: Ben Crabtree <bencrab@amazon.com>
Co-authored-by: rrrkharse <91350438+rrrkharse@users.noreply.github.com>
Co-authored-by: IshaChid76 <49986634+IshaChid76@users.noreply.github.com>
Co-authored-by: isha chidrawar <ishachid@amazon.com>
Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com>
Co-authored-by: cj-zhang <32367995+cj-zhang@users.noreply.github.com>
Co-authored-by: Joseph Zhang <cjz@amazon.com>
Co-authored-by: pintaoz-aws <167920275+pintaoz-aws@users.noreply.github.com>
Co-authored-by: pintaoz <pintaoz@amazon.com>
Co-authored-by: Keshav Chandak <keshav.chandak1995@gmail.com>
Co-authored-by: Keshav Chandak <chakesh@amazon.com>
Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: Bruno Pistone <brn.pistone@gmail.com>
Co-authored-by: evakravi <69981223+evakravi@users.noreply.github.com>
Co-authored-by: Victor Zhu <viczhu@amazon.com>
HollowTube pushed a commit to HollowTube/sagemaker-python-sdk that referenced this pull request Jul 15, 2025
@pintaoz-aws
Skip tests failed due to deprecated instance type (aws#5097)
89493da 
Co-authored-by: pintaoz <pintaoz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benieric benieric benieric left review comments

@sage-maker sage-maker sage-maker approved these changes

@chad119 chad119 Awaiting requested review from chad119 chad119 is a code owner automatically assigned from aws/sagemaker-ml-frameworks

@nargokul nargokul Awaiting requested review from nargokul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pintaoz-aws @benieric @nargokul @sage-maker