Skip to content

fix: wrap test horovod code inside main function #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2019
Merged

fix: wrap test horovod code inside main function #739

merged 2 commits into from
Apr 5, 2019

Conversation

mvsusp
Copy link
Contributor

@mvsusp mvsusp commented Apr 4, 2019

Description of changes:

  • test_horovod.py is having flaky behavior. The tests was not printing the rank properly, making it hard to debug the issue. I'm wrapping the script in a main function and printing the file contents, allowing easier debuggability.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mvsusp mvsusp requested a review from jesterhazy April 4, 2019 23:55
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mvsusp mvsusp merged commit 398f4e8 into aws:master Apr 5, 2019
@mvsusp mvsusp deleted the mvs-test-hvd-fix branch April 5, 2019 03:16
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 13, 2022
@danabens @qidewenwhen
Add async metrics sink (aws#739)
61af29b 
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 14, 2022
@danabens @qidewenwhen
Add async metrics sink (aws#739)
d206738 
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 14, 2022
@danabens @qidewenwhen
Add async metrics sink (aws#739)
df343ce 
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 14, 2022
@danabens @qidewenwhen
Add async metrics sink (aws#739)
599aadb 
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
qidewenwhen added a commit to qidewenwhen/sagemaker-python-sdk that referenced this pull request Dec 14, 2022
@danabens @qidewenwhen
Add async metrics sink (aws#739)
25299c4 
Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>
navinsoni pushed a commit that referenced this pull request Dec 14, 2022
@qidewenwhen @danabens @yzhu0
feature: Add SageMaker Experiment (#3536)
93a8466 
* feature: Add experiment plus Run class (#691)

* feature: Add Experiment helper classes (#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (#696)

* change: Update Run init and add Run load and _RunContext (#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (#754)

* fix flaky metrics test (#753)

* change: Change Run.init and Run.load to constructor and module method respectively (#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (#767)

* Change: Minimize use of lower case tc name (#769)

* change: Clean up test resources to remove model files (#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
claytonparnell pushed a commit to claytonparnell/sagemaker-python-sdk that referenced this pull request Dec 16, 2022
@qidewenwhen @danabens
@yzhu0 @claytonparnell
feature: Add SageMaker Experiment (aws#3536)
d48e989 
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
mufaddal-rohawala pushed a commit to mufaddal-rohawala/sagemaker-python-sdk that referenced this pull request Dec 19, 2022
@qidewenwhen @danabens
@yzhu0 @mufiAmazon
feature: Add SageMaker Experiment (aws#3536)
46fcc16 
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
mufaddal-rohawala pushed a commit that referenced this pull request Dec 20, 2022
@qidewenwhen @danabens
@yzhu0 @mufiAmazon
feature: Add SageMaker Experiment (#3536)
02f0c3c 
* feature: Add experiment plus Run class (#691)

* feature: Add Experiment helper classes (#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (#696)

* change: Update Run init and add Run load and _RunContext (#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (#754)

* fix flaky metrics test (#753)

* change: Change Run.init and Run.load to constructor and module method respectively (#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (#767)

* Change: Minimize use of lower case tc name (#769)

* change: Clean up test resources to remove model files (#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@qidewenwhen @danabens
@yzhu0 @JoseJuan98
feature: Add SageMaker Experiment (aws#3536)
9d734a0 
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023
@qidewenwhen @danabens
@yzhu0 @JoseJuan98
feature: Add SageMaker Experiment (aws#3536)
232d891 
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023
@qidewenwhen @danabens @yzhu0
feature: Add SageMaker Experiment (aws#3536)
34ca4dd 
* feature: Add experiment plus Run class (aws#691)

* feature: Add Experiment helper classes (aws#646)

* feature: Add Experiment helper classes

feature: Add helper class _RunEnvironment

* change: Change sleep retry to backoff retry for get TC

* minor fixes in backoff retry

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add helper classes and methods for Run class (aws#660)

* feature: Add helper classes and methods for Run class

* Add Parent class to address comment

* fix docstyle check

* Add arg docstrings in _helper

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add Experiment Run class (aws#651)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Add integ tests for Run (aws#673)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Update run log metric to use MetricsManager (aws#678)

* Update run.log_metric to use _MetricsManager

* fix several metrics issues

* Add doc strings to metrics.py

Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Dewen Qi <qidewen@amazon.com>

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>

* change: Simplify exp plus integ test configuration (aws#694)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: add RunName to expeirment_config (aws#696)

* change: Update Run init and add Run load and _RunContext (aws#707)

* change: Update Run init and add Run load

Add exp name and run group name to load and address comments

* Address nit comments

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* fix: Fix run name uniqueness issue (aws#730)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* change: Update integ tests for Exp Plus M1 changes (aws#741)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* add metrics client to session object (aws#745)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* change: Add integ test for using Run in Transform Job (aws#749)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* Add async metrics sink (aws#739)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* use metrics client provided by session (aws#754)

* fix flaky metrics test (aws#753)

* change: Change Run.init and Run.load to constructor and module method respectively (aws#752)

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* feature: Add latest metric service model (aws#757)

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: qidewenwhen <32910701+qidewenwhen@users.noreply.github.com>

* fix: lowercase run name (aws#767)

* Change: Minimize use of lower case tc name (aws#769)

* change: Clean up test resources to remove model files (aws#756)

* change: Clean up test resources to remove model files

* fix: Change experiment enums to upper case

* change: Upgrade boto3 and update test to validate mixed case name

* fix: Update as per latest botocore release and backend change

Co-authored-by: Dewen Qi <qidewen@amazon.com>

* lowercase trial component name (aws#776)

* change: Expose sagemaker experiment doc strings

* fix: Fix exp name mixed case in issue

Co-authored-by: Dewen Qi <qidewen@amazon.com>
Co-authored-by: Dana Benson <danabens@amazon.com>
Co-authored-by: Dana Benson <31262102+danabens@users.noreply.github.com>
Co-authored-by: Yifei Zhu <66866419+yzhu0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jesterhazy jesterhazy jesterhazy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvsusp @jesterhazy