Skip to content

Conversation

saimidu
Copy link
Contributor

@saimidu saimidu commented Apr 10, 2020

Description of changes:
PR for EI dockerfile corresponding to #63

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@saimidu saimidu requested a review from dfan April 13, 2020 00:07
Copy link
Contributor

@dfan dfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As long as importing torch, torchvision, and loading a torchvision pretrained model still works.

@TusharKanekiDey TusharKanekiDey self-requested a review April 13, 2020 00:15
@TusharKanekiDey
Copy link
Contributor

LGTM. For py2 container , If in case u already do not know, Please upgrade the urllib3 package to 1.25.8.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@saimidu saimidu merged commit eed2f5e into aws:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants