chore: make MSK tests non-blocking

[hoffa]

Issue #, if available

Description of changes

Encountering flakiness every blue moon with this tests; added equivalent transform tests and marking as non-blocking since we've already tested it.

For reference, the guidelines for marking tests as @nonblocking are:

serverless-application-model/integration/helpers/base_test.py

Lines 57 to 63 in 801c3fc

	# In general, we should only mark integration tests as @nonblocking if
	# 1. The test succeeded every region (this ensures the transformed output makes sense)
	# 2. The test resources are defined in a single template without Parameters or other
	# CloudFormation macros (this ensures we can represent transform using a transform test)
	# 3. An identical transform test exists for the integration test template (this ensures we
	# don't break the working template)
	nonblocking = pytest.mark.xfail

In this case we do use Parameters. Specifically, the tests use these subnets:

serverless-application-model/integration/resources/templates/combination/function_with_msk.yaml

Lines 34 to 40 in 801c3fc

	MyMskCluster:
	Type: AWS::MSK::Cluster
	Properties:
	BrokerNodeGroupInfo:
	ClientSubnets:
	- Ref: PreCreatedSubnetOne
	- Ref: PreCreatedSubnetTwo

serverless-application-model/integration/combination/test_function_with_msk.py

Lines 55 to 59 in 801c3fc

	def get_parameters(self, dictionary):
	parameters = []
	parameters.append(self.generate_parameter("PreCreatedSubnetOne", dictionary["PreCreatedSubnetOne"]))
	parameters.append(self.generate_parameter("PreCreatedSubnetTwo", dictionary["PreCreatedSubnetTwo"]))
	return parameters

Created by the companion stack:

serverless-application-model/integration/setup/companion-stack.yaml

Lines 49 to 56 in 801c3fc

	PreCreatedSubnetTwo:
	Description: 'Pre-created #2 subnet that can be used inside other tests'
	Value:
	Ref: PreCreatedSubnetTwo
	PreCreatedSubnetOne:
	Description: 'Pre-created #1 subnet that can be used inside other tests'
	Value:
	Ref: PreCreatedSubnetOne

However those parameters don't have any SAM-specific handling since they're passed straight to AWS::MSK::Cluster, so we can be more lax on (2).

For transform test had to replace CodeUri to make it work with local transform.

Description of how you validated changes

With outdated credentials:

pytest integration --no-cov -k msk

==== 188 deselected, 2 xfailed, 2 warnings in 1.79s ====

Checklist

• Adheres to the development guidelines
• Add/update transform tests
  • Using correct values
  • Using wrong values
• Add/update integration tests

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.