Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot 2 sample is broken #484

Closed
taasjord opened this issue Nov 10, 2022 · 3 comments
Closed

Spring Boot 2 sample is broken #484

taasjord opened this issue Nov 10, 2022 · 3 comments
Assignees

Comments

@taasjord
Copy link

Serverless Java Container version: 1.9

Implementations: Spring Boot 2

In commit 0b92c8e the API gateway and stack output was commented out, replaced by function URL.

Problems:

  1. Readme/deploy instructions and sample code no longer matching.
  2. Attempting to call the function URL results in "Internal server error" and exception:
    com.amazonaws.serverless.exceptions.InvalidRequestEventException: The incoming event is not a valid request from Amazon API Gateway or an Application Load Balancer

While I was able to fix it by uncommenting the template resources, but not a pleasant sample application experience testing this for the first time. I don't know if the intention was to actually change to function URLs, but it looks like some code needs to be changed as well.

@deki deki self-assigned this Nov 10, 2022
@deki
Copy link
Collaborator

deki commented Nov 10, 2022

Thanks for the issue report, that change was not supposed to be part of the commit. Will revert it.

deki added a commit to deki/aws-serverless-java-container that referenced this issue Nov 10, 2022
@taasjord
Copy link
Author

Kudos for exceptional Time-to-Commit response time ;)

@deki
Copy link
Collaborator

deki commented Nov 10, 2022

Of course, samples must always work :-)

@deki deki closed this as completed Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants