-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated Manifest of Build Artifacts #283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
reviewed
Apr 6, 2021
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ManifestWriter.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ManifestWriter.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ManifestWriter.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ManifestWriter.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ManifestWriter.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ManifestWriter.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SemanticVersion.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SemanticVersion.java
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SemanticVersion.java
Outdated
Show resolved
Hide resolved
jasdel
reviewed
Apr 7, 2021
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/CodegenVisitor.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ManifestWriter.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ManifestWriter.java
Outdated
Show resolved
Hide resolved
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SemanticVersion.java
Outdated
Show resolved
Hide resolved
...n/smithy-go-codegen/src/test/java/software/amazon/smithy/go/codegen/SemanticVersionTest.java
Show resolved
Hide resolved
skmcgrail
force-pushed
the
manifestBuildArtifact
branch
from
April 7, 2021 19:49
066ad7e
to
cc4b465
Compare
skmcgrail
force-pushed
the
manifestBuildArtifact
branch
3 times, most recently
from
April 10, 2021 00:03
c66217f
to
2084f99
Compare
skmcgrail
force-pushed
the
manifestBuildArtifact
branch
2 times, most recently
from
April 14, 2021 19:43
1e527cb
to
7d6a773
Compare
jasdel
approved these changes
Apr 27, 2021
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/ManifestWriter.java
Show resolved
Hide resolved
skmcgrail
force-pushed
the
manifestBuildArtifact
branch
from
May 5, 2021 00:56
3bbd461
to
fc8d900
Compare
…to support vN module version paths.
skmcgrail
force-pushed
the
manifestBuildArtifact
branch
from
May 10, 2021 23:09
fc8d900
to
44b6a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a generated manifest of the build output artifacts. Introduces the ability to handle selection of the minimum required standard library, and minimum version required for a given set of dependencies. This manifest will be used to ultimately remove the responsibilities of generating the
go.mod
from the smithy-go code base and move that concern into the SDK.Example
generated.json
from thesmithy-go-codegen-test
test code: