This repository was archived by the owner on Jun 15, 2023. It is now read-only.
document that CF action RoleArn needs access to the template, but CF service role doesn't #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…service role doesn't
2 tasks
|
Hello, Thank you for your input! This is a great way to clarify this nuanced information for the action. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
It appears (although I'm partly guessing and going off aws/aws-cdk#12985 (comment), and an error I got when the action deploy role didn't have s3 permissions) that the CloudFormation action generates a signed URL to the template, and passes that signed URL to CloudFormation.
This means the CloudFormation service role does not need permission to access the artifact bucket, because the signed URL is publicly accessible.
Also it means the action
RoleArn(if configured), does need access to the artifact bucket, to generate the signed URL.Would be great to get confirmation that this is how it works and the docs updated to make this clear.