Clarify wording on failure for poll-based event sources that are not stream-based #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stream-based The original phrasing "When a message is not successfully processed" seems to indicate that something happens on each failed attempt to process the message, but that is not the case. Something happens after a period of time if all attempts to process have failed or no attempts have been made. In short, when the message has not been processed successfully. Also, it is the failed message that is sent to the Dead-Letter Queue. No information about why it failed is sent.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The original phrasing "When a message is not successfully processed" seems to indicate that something happens on each failed attempt to process the message, but that is not the case. Something happens after a period of time if all attempts to process have failed or no attempts have been made. In short, when the message has not been processed successfully.
Also, it is the failed message that is sent to the Dead-Letter Queue. No information about why it failed is sent.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.