Fix typo in adding RIE to the image example #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's inconsistency in the example of how to add RIE to the image. Dockerfile `ADD` and `RUN` commands work with `/usr/bin/aws-lambda-rie`. But `entry.sh` script refers to `/usr/local/bin/aws-lambda-rie` that causes issues. Alternatively, Dockerfile `ADD` and `RUN` commands can be updated to work with `/usr/local/bin/aws-lambda-rie`.
|
Thank you for finding the discrepancy in the procedure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There's inconsistency in the example of how to add RIE to the image.
Dockerfile
ADDandRUNcommands work with/usr/bin/aws-lambda-rie. Butentry.shscript refers to/usr/local/bin/aws-lambda-riethat causes issues.Alternatively, Dockerfile
ADDandRUNcommands can be updated to work with/usr/local/bin/aws-lambda-rie.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.