Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check CI #254

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Version check CI #254

merged 1 commit into from
Apr 25, 2024

Conversation

disa6302
Copy link
Contributor

Issue #, if available:

What was changed?

  • Adding a new job that will flag if a PR getting merged into master does not have version updated.

Why was it changed?

  • To ensure the CMake file is being changed before cutting a new release.
  • To also ensure no changes get merged to master unless a new version is being released.

How was it changed?

  • Added a new yml file to grep the cmake file for version.

What testing was done for the changes?

  • Tested with develop branch to confirm it works fine.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.44%. Comparing base (2b835f3) to head (70aafc9).
Report is 12 commits behind head on develop.

❗ Current head 70aafc9 differs from pull request most recent head 6ba2e85. Consider uploading reports for the commit 6ba2e85 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
+ Coverage    80.34%   80.44%   +0.09%     
===========================================
  Files           53       53              
  Lines        10808    10826      +18     
===========================================
+ Hits          8684     8709      +25     
+ Misses        2124     2117       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disa6302 disa6302 marked this pull request as ready for review April 25, 2024 18:49
@disa6302 disa6302 merged commit e96735d into develop Apr 25, 2024
14 checks passed
@sirknightj sirknightj deleted the version-check-ci branch April 25, 2024 21:10
@sirknightj sirknightj added the ci label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants