Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMSException is a little overused on concrete classes #8

Closed
jgangemi opened this issue Mar 18, 2015 · 1 comment
Closed

JMSException is a little overused on concrete classes #8

jgangemi opened this issue Mar 18, 2015 · 1 comment

Comments

@jgangemi
Copy link

if the concrete implementation doesn't explicitly throw a JMSException, it does not need to be declared as part of the method signature. for example, SQSMessageConsumer.setMessageListener does not need to declare this exception.

i have a desire to use this implementation and i'm ok w/ using the SQS* classes directly (i'm wrapping them in other code). not having to deal w/ these exceptions when they aren't actually thrown would be helpful and help simplify the underlying code.

there also seems to be inconsistency in how RuntimeException subclasses are handled. in some cases, they are re-wrapped and re-thrown as JMSExceptions (bleh). in other cases, they are not.

@kuba-aws
Copy link
Contributor

Marking as feature request to review the way exceptions are handled, rethrown and declared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants