Add logging to MQTT #68
Conversation
| @@ -308,18 +333,21 @@ struct aws_mqtt_client_connection *aws_mqtt_client_connection_new(struct aws_mqt | |||
|
|
|||
| if (aws_mutex_init(&connection->pending_requests.mutex)) { | |||
|
|
|||
| goto handle_error; | |||
| AWS_LOGF_ERROR(AWS_LS_MQTT_CLIENT, "Failed to initialize pending_requests mutex"); | |||
| goto failed_init_pending_requests_mutex; | |||
There was a problem hiding this comment.
Given the ZERO_STRUCT call here, it seems like this could be cleaned up to have a single on_error that destroys the connection, which would simplify the logic a lot. Your destroy might need to be made a bit more paranoid in spots to make sure it handles the partial construction cases.
There was a problem hiding this comment.
When deciding what should be TRACE/DEBUG/INFO, I found it helpful to look at the output from running the same test at each of those 3 log levels. When you see everything together, it helps give a good feel for what belongs and what doesn't.
Take a look at the description on the HTTP-logging PR. I put what the logs look like at each level.
|
Would you mind if I harassed you to paste what the logs looked like at TRACE/DEBUG/INFO levels when running something simple like a pub/sub sample? connect, sub, pub, receive, disconnect |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.