Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support machines with multiple NICs #444

Merged
merged 32 commits into from
Jul 11, 2024
Merged

Support machines with multiple NICs #444

merged 32 commits into from
Jul 11, 2024

Conversation

waahm7
Copy link
Contributor

@waahm7 waahm7 commented Jun 28, 2024

Issue #, if available:
#415

Description of changes:

  • Adds an option to take a list of interface names and distribute connections across multiple NIC.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.62%. Comparing base (51e24fe) to head (757d613).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   89.60%   89.62%   +0.02%     
==========================================
  Files          20       20              
  Lines        6070     6092      +22     
==========================================
+ Hits         5439     5460      +21     
- Misses        631      632       +1     
Files Coverage Δ
source/s3_endpoint.c 91.11% <100.00%> (+0.13%) ⬆️
source/s3_client.c 88.06% <95.45%> (+0.12%) ⬆️

@waahm7 waahm7 changed the title WIP | bind network interface names list Support machines with multiple NICs Jul 8, 2024
@waahm7 waahm7 marked this pull request as ready for review July 8, 2024 16:49
include/aws/s3/private/s3_client_impl.h Outdated Show resolved Hide resolved
Co-authored-by: Michael Graeb <graebm@amazon.com>
source/s3_client.c Outdated Show resolved Hide resolved
waahm7 and others added 2 commits July 10, 2024 10:24
@waahm7 waahm7 merged commit 94edd47 into main Jul 11, 2024
30 checks passed
@waahm7 waahm7 deleted the bind-network-interface branch July 11, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants