Add crc helpers for writing to large buffers. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMusatkin
changed the title
graebm
reviewed
Sep 5, 2024
graebm
approved these changes
Sep 5, 2024
| #include <limits.h> | ||
|
|
||
| #define large_buffer_apply_impl(Name, T) \ | ||
| T aws_large_buffer_apply_##Name( \ |
There was a problem hiding this comment.
Suggested change
| T aws_large_buffer_apply_##Name( \ | |
| static T aws_large_buffer_apply_##Name( \ |
There was a problem hiding this comment.
Or don't declare a separate function here, just have it be the implementation like:
#define CHECKSUM_WITH_SIZE_IMPL(Name, T) \
... \
return val
and then
uint32_t aws_checksums_crc32_with_size(const uint8_t *input, size_t length, uint32_t previous_crc32) {
CHECKSUM_WITH_SIZE_IMPL(aws_checksums_crc32, uint32_t);
}
There was a problem hiding this comment.
i prefer to keep a separate function here, mostly to sanity check that function pointer prototype has args that match the other args passed to this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
we defined all crc functions to take int for length and then in every binding we have code to work around buffers that are more than INT_MAX.
This just add same helper here so we can skip repeating it in every binding.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.