Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched JNI call on proxy auth enum #779

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Mismatched JNI call on proxy auth enum #779

merged 1 commit into from
Apr 17, 2024

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Apr 16, 2024

aws/aws-iot-device-sdk-java-v2#574

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xiazhvera
Copy link
Contributor

The PR looks good to me.
Though it's interesting that the unit tests did not catch it. I will verify the unit tests before we bring the changes in. Please hold on the PR for now.

@xiazhvera
Copy link
Contributor

The fix is verified on a local android test.

@xiazhvera xiazhvera merged commit 5d62d97 into main Apr 17, 2024
42 checks passed
@xiazhvera xiazhvera deleted the Mqtt5ProxyJni branch April 17, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JNI crash when trying to build Mqtt5Client with proxy on Android
2 participants