Browser qos0 publish fix #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistedTwigleg
approved these changes
Jun 23, 2022
bretambrose
added a commit
that referenced
this pull request
Nov 25, 2022
* Fix package version issue (#324) * try install npm-force-resolution in builder steps * Specify exact versions in all resolutions * revert builder changes * Update Auth Interface (#319) * unify the interface for auth between node and browser * revert config infor * setup refresh function for identity * fix file format * unitfy native interface * update credential naming and configuration members * update sample with new interface * update browser pub_sub sample with new auth interface * clean up code base * update interface * fix interface errors brought by interface update * update updateCredentialCallback work flow, call it on interruption * setup default session expiration time to 1 hour * Implement CredentialProvider for js browser. Added support for CognitoCredentialProvider * clean up the source code * update nodejs browser exported interface * Fix EOF and spacing * Update the credentials provider interface. Move credentials_provider to MqttConnectionConfig. * update credentials provider interface * 1)setup static credentials provider if credentials are set in option. 2)Remove StaticCredentialsOptions * Browser Reconnect Backoff (#322) * WIP - expose MQTT reconnect backoff times, implement reconnect backoff for browser that works like native * unify the interface for auth between node and browser * WIP: reconnect backoff * revert config infor * setup refresh function for identity * fix file format * unitfy native interface * update credential naming and configuration members * update sample with new interface * update browser pub_sub sample with new auth interface * clean up code base * update interface * fix interface errors brought by interface update * update updateCredentialCallback work flow, call it on interruption * setup default session expiration time to 1 hour * Implement CredentialProvider for js browser. Added support for CognitoCredentialProvider * clean up the source code * update nodejs browser exported interface * Fix EOF and spacing * Update the credentials provider interface. Move credentials_provider to MqttConnectionConfig. * add reconnect logic and re-subscription * update sample add the message counter * clean up debug logs * revert reconnect changes * extend reconnectPeriod to have reconnect backoff works * reset arguments number for mqtt_client_connection_connect * added interface to setup reconnection period * remove sapce * update credentials provider interface * add default reconnection time outs * 1)setup static credentials provider if credentials are set in option. 2)Remove StaticCredentialsOptions * 1.clamp reconnection time out values in JS lib 2.use Math.pow to caculate the reconnection back off * remove reconnection clamping from binding layer * remove reconnection clamping from binding layer * fix format * fix wrong spacing Co-authored-by: Michael Graeb <graebm@amazon.com> * Bump async from 2.6.3 to 2.6.4 in /samples/browser/pub_sub (#314) Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/caolan/async/releases) - [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md) - [Commits](caolan/async@v2.6.3...v2.6.4) --- updated-dependencies: - dependency-name: async dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dengke Tang <dengket@amazon.com> * dependency updates (#308) * Bump minimist from 1.2.5 to 1.2.6 in /samples/browser/http * Bump async from 2.6.3 to 2.6.4 in /samples/browser/http * Bump async from 2.6.3 to 2.6.4 in /samples/browser/pubsub * Dependency version updates (#329) * removed npm-force-resolutions * update mqtt dependency * added specific version of prettier to devDependencies * removed package-lock from samples * Fix packetid query failure on qos 0 browser publishes (#330) * Typescript upgrade (#332) * Update typescript to latest * Update typedoc to almost-latest MV * Update typedoc config to account for all the breaking changes * Swap typedoc plugins to modern ones that still work and do approximately what we had plugins doing before. * Rework how events are documented * Move some private browser mqtt connection functionality to the bottom of the class definition * Move some problematic type definitions that used CrtError (which is defined in browser/native) down to browser/native * Expose checksums as an export * Fix some messy type errors due to stricter checking in 4.x * Update sample package.jsons * Update to latest main in aws-c-mqtt-staging rather than mqtt5 branch Co-authored-by: xiazhvera <zhvxia@amazon.com> Co-authored-by: Michael Graeb <graebm@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dengke Tang <dengket@amazon.com> Co-authored-by: Steve Kim <86316075+sbSteveK@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.