Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(core|cli) enable EventBridge notifications; remove CloudTrail; update CDK version #83

Merged
merged 6 commits into from
Apr 12, 2022
Merged

(core|cli) enable EventBridge notifications; remove CloudTrail; update CDK version #83

merged 6 commits into from
Apr 12, 2022

Conversation

kukushking
Copy link
Contributor

@kukushking kukushking commented Apr 8, 2022 •
edited
Loading

Feature or Bugfix

  • Feature

Detail

  • Add event_bridge_enabled to bucket factory
  • Remove CloudTrail from S3EventStage
  • Update event patterns on S3EventStage & Kinesis stage
  • Update CDK version

Relates

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking kukushking added enhancement New feature or request core cli labels Apr 8, 2022
@kukushking kukushking self-assigned this Apr 8, 2022
jaidisido
jaidisido approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment

core/aws_ddk_core/resources/_s3.py Outdated Show resolved Hide resolved
jaidisido
jaidisido requested changes Apr 9, 2022
View reviewed changes
core/aws_ddk_core/stages/s3_event.py Outdated Show resolved Hide resolved
core/aws_ddk_core/stages/kinesis_s3.py Outdated Show resolved Hide resolved
@kukushking kukushking merged commit eee0cf3 into main Apr 12, 2022
@jaidisido jaidisido deleted the feat-eventbridge-bucket-notifications branch April 14, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaidisido jaidisido jaidisido approved these changes

Assignees

@kukushking kukushking

Labels
cli core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kukushking @jaidisido