Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for sub deployment_map files #79

Merged
merged 6 commits into from
Jun 28, 2019
Merged

Conversation

triha74
Copy link
Contributor

@triha74 triha74 commented Jun 26, 2019

Issue #78:

Description of changes: Added support for loading deployment_map files form a deployment_map dir.

The code loads deployment_map.yml then if there is a deployment_map dir and it has content it loads any yml files in there. The deployment_map/*.yml follow the exact same format as the deployment_map.yml. The loaded subfiles are merged with the pipelines list of the deployment_map.yml. If there was not deployment_map.yml it creates an empty pipelines array that it subsquently fills with content from subfiles.

Example 1.

RihaDevTeam:~/environment/adf/deploy/aws-deployment-framework-pipelines (master) $ ls
adf-build  deployment_map  deployment_map.yml  pipeline_types  pytest.ini
RihaDevTeam:~/environment/adf/deploy/aws-deployment-framework-pipelines (master) $ 
RihaDevTeam:~/environment/adf/deploy/aws-deployment-framework-pipelines (master) $ ls deployment_map
example-lib-python.yml       example-service-authentication.yml
example-service-dynamo.yml   example-service-dynamo.yml

Example 2.

RihaDevTeam:~/environment/adf/deploy/aws-deployment-framework-pipelines (master) $ ls
adf-build  deployment_map  deployment_map.yml  pipeline_types  pytest.ini
RihaDevTeam:~/environment/adf/deploy/aws-deployment-framework-pipelines (master) $ 
RihaDevTeam:~/environment/adf/deploy/aws-deployment-framework-pipelines (master) $ ls deployment_map
team-alpha.yml             team-beta.yml

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bundyfx bundyfx added the enhancement New feature or request label Jun 26, 2019
@@ -20,8 +21,10 @@ def __init__(
map_path=None
):
self.map_path = map_path or 'deployment_map.yml'
self.map_dir_path = map_path or 'deployment_map'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we called the folder "maps" or "deployment_maps" since it will probably hold multiple

@bundyfx bundyfx merged commit fd26b5b into awslabs:master Jun 28, 2019
@bundyfx
Copy link
Contributor

bundyfx commented Jun 28, 2019

Thanks! Merged! 💯 - will go into the 1.10 bundle on the SAR which should be up by tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants