Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECS credential provider #353

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Add ECS credential provider #353

merged 2 commits into from
Oct 20, 2021

Conversation

kggilmer
Copy link
Contributor

Issue #

#18

Description of changes

  • Add ECS credential provider in SDK

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@aajtodd aajtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any documentation on how to test these?

I know CRT hides all the configuration that would ultimately allow us to setup integration tests. Next best thing would be how to test each provider manually (setup, scenarios, etc).

@kggilmer
Copy link
Contributor Author

Is there any documentation on how to test these?

I've documented the manual testing I've done for this particular CRT provider in notes here: awslabs/aws-crt-java#389

I am unaware of ways of unit testing these based on how they are implemented in CRT. I've filed an issue to make the ports configurable from Java in this case to allow us to do some testing. Until/if that's implemented I am not aware of a way we can test in CI.

Regarding STS, I have been unable to find documentation that describes the basic happy-path workflow for either assume role or web identity. I have done some manual testing but without knowing what service-side configuration is required, it's not possible to really know if the ad-hoc tests are valid.

The same applies regarding ports and instrumentation for STS as it does to ECS.

@kggilmer kggilmer merged commit 69a3dfd into main Oct 20, 2021
@kggilmer kggilmer deleted the feat-ecs-credential-provider branch October 20, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants