Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-config: Fix compilation error with rustls and native-tls disabled #576

Closed

Conversation

joshtriplett
Copy link
Contributor

The ProviderConfig::with_tcp_connector method uses
aws_smithy_client::hyper_ext, which only exists with the
client-hyper feature enabled. Add a feature enabling that, and enable
it by default.

Introducing this feature does not cause breakage, because aws-config
did not previously compile with default-features = false and neither
rustls nor native-tls enabled.

Motivation and Context

Without this change:

error[E0433]: failed to resolve: could not find `hyper_ext` in `aws_smithy_client`
   --> /home/josh/.cargo/registry/src/github.com-1ecc6299db9ec823/aws-config-0.15.0/src/provider_config.rs:251:50
    |
251 |             let mut builder = aws_smithy_client::hyper_ext::Adapter::builder()
    |                                                  ^^^^^^^^^ could not find `hyper_ext` in `aws_smithy_client`

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…sabled

The `ProviderConfig::with_tcp_connector` method uses
`aws_smithy_client::hyper_ext`, which only exists with the
`client-hyper` feature enabled. Add a feature enabling that, and enable
it by default.

Introducing this feature does not cause breakage, because aws-config
did not previously compile with `default-features = false` and neither
`rustls` nor `native-tls` enabled.
@joshtriplett joshtriplett requested a review from a team as a code owner July 6, 2022 06:19
@joshtriplett
Copy link
Contributor Author

Just realized I missed the generated-code note in Cargo.toml here (and there wasn't one in the .rs file). Will send to smithy-rs instead.

@joshtriplett joshtriplett deleted the aws-config-client-hyper branch July 6, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant