Fix all cfn_nag findings #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnfait
force-pushed
the
cfnnag-cleanup
branch
3 times, most recently
from
86087eb
to
c1fb5ff
Compare
notably: add access logs bucket in devops account
also regroup black and ruff under a single python job
cnfait
force-pushed
the
cfnnag-cleanup
branch
from
c1fb5ff
to
75d9979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix all cfn_nag findings. Notably: add access logs bucket in devops account.
Add cfn_nag in GitHub static checking workflow so that it's checked when a pull request is opened/updated. Also regroup black and ruff under a single python job.
Two files are excluded from cfn_nag_scan due to the tool not supporting fn::foreach.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.