Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backward compatible for alb updating custom resource #1476

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

dengmingtong
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Summary

compatible from v1 upgrading to v2

Implementation highlights

(describe how the merge request does for feature changes, share the RFC link if it has)

Test checklist

  • add new test cases
  • all code changes are covered by unit tests
  • end-to-end tests
    • deploy web console with CloudFront + S3 + API gateway
    • deploy web console within VPC
    • deploy ingestion server
      • with MSK sink
      • with KDS sink
      • with S3 sink
    • deploy data processing
    • deploy data modeling
      • new Redshift Serverless
      • provisioned Redshift
      • Athena
    • deploy with reporting
    • streaming ingestion
      • with Redshift Serverless
      • with provisioned Redshift

Is it a breaking change

  • add parameters without default value in stack
  • introduce new service permission in stack
  • introduce new top level stack module

Miscellaneous

  • introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

Copy link

Etl common library's test coverage

Overall Project 93.08% 🍏

There is no coverage information present for the Files changed

Copy link

Streaming ingestion flink application's test coverage

Overall Project 93.69% 🍏

There is no coverage information present for the Files changed

@dengmingtong dengmingtong requested a review from zxkane June 24, 2024 07:53
Copy link

Data Pipeline spark application's test coverage

Overall Project 98.15% 🍏

There is no coverage information present for the Files changed

Copy link

Code Coverage

Package Line Rate Branch Rate Health
src 100% 88%
src.analytics 100% 100%
src.analytics.lambdas 92% 88%
src.analytics.lambdas.clear-expired-events-workflow 100% 100%
src.analytics.lambdas.custom-resource 96% 87%
src.analytics.lambdas.load-data-workflow 99% 89%
src.analytics.lambdas.refresh-materialized-views-workflow 96% 88%
src.analytics.lambdas.scan-metadata-workflow 97% 88%
src.analytics.lambdas.sql-execution-sfn 93% 60%
src.analytics.lambdas.user-segments-workflow 96% 77%
src.analytics.private 100% 92%
src.analytics.private.athena 100% 100%
src.analytics.private.segments 100% 100%
src.base-lib.src 100% 100%
src.base-lib.src.auth 89% 65%
src.base-lib.src.common 97% 80%
src.base-lib.src.constant 100% 100%
src.base-lib.src.model 100% 100%
src.common 98% 80%
src.common.lambda 97% 86%
src.control-plane 99% 71%
src.control-plane.auth 93% 12%
src.control-plane.backend 100% 84%
src.control-plane.backend.lambda.api 97% 33%
src.control-plane.backend.lambda.api.common 92% 80%
src.control-plane.backend.lambda.api.middle-ware 88% 79%
src.control-plane.backend.lambda.api.model 94% 52%
src.control-plane.backend.lambda.api.router 98% 97%
src.control-plane.backend.lambda.api.service 84% 66%
src.control-plane.backend.lambda.api.service.quicksight 93% 82%
src.control-plane.backend.lambda.api.service.segments 95% 76%
src.control-plane.backend.lambda.api.store.aws 86% 55%
src.control-plane.backend.lambda.api.store.dynamodb 90% 79%
src.control-plane.backend.lambda.api.test.api 99% 82%
src.control-plane.backend.lambda.api.test.api.segments 100% 100%
src.control-plane.backend.lambda.batch-insert-ddb 94% 86%
src.control-plane.backend.lambda.listen-stack-status 81% 49%
src.control-plane.backend.lambda.listen-state-status 91% 50%
src.control-plane.backend.lambda.sfn-action 88% 50%
src.control-plane.backend.lambda.sfn-workflow 74% 68%
src.control-plane.backend.layer.lambda-web-adapter 98% 40%
src.control-plane.private 100% 100%
src.data-pipeline 100% 100%
src.data-pipeline.lambda.copy-assets 97% 90%
src.data-pipeline.lambda.emr-job-state-listener 97% 92%
src.data-pipeline.lambda.emr-job-submitter 99% 77%
src.data-pipeline.lambda.emr-serverless-app 96% 86%
src.data-pipeline.lambda.partition-syncer 98% 89%
src.data-pipeline.tables 100% 100%
src.data-pipeline.utils 100% 97%
src.ingestion-server.common-resources 100% 71%
src.ingestion-server.custom-resource 100% 100%
src.ingestion-server.custom-resource.delete-ecs-cluster 98% 90%
src.ingestion-server.custom-resource.update-alb-rules 90% 74%
src.ingestion-server.kafka-s3-connector 100% 100%
src.ingestion-server.kafka-s3-connector.custom-resource.kafka-s3-sink-connector 96% 82%
src.ingestion-server.kinesis-data-stream 100% 100%
src.ingestion-server.kinesis-data-stream.kinesis-to-s3-lambda 100% 100%
src.ingestion-server.kinesis-data-stream.private 100% 100%
src.ingestion-server.server 98% 89%
src.ingestion-server.server-v2 100% 95%
src.ingestion-server.server-v2.private 99% 83%
src.ingestion-server.server.private 100% 90%
src.metrics 100% 100%
src.metrics.custom-resource.add-sns-subscription 95% 86%
src.metrics.custom-resource.get-interval 99% 97%
src.metrics.custom-resource.put-dashboard 97% 84%
src.metrics.custom-resource.set-metrics-widgets 98% 93%
src.private 96% 73%
src.reporting 100% 82%
src.reporting.lambda.custom-resource.quicksight 94% 81%
src.reporting.private 90% 54%
src.streaming-ingestion 100% 100%
src.streaming-ingestion.lambdas.custom-resource 86% 63%
src.streaming-ingestion.private 99% 89%
src.streaming-ingestion.redshift 100% 100%
test 96% 83%
test.common 93% 100%
test.control-plane 97% 64%
test.ingestion-server.server 97% 88%
Summary 96% (77920 / 81406) 74% (6587 / 8876)

Minimum allowed line rate is 60%

@zxkane
Copy link
Contributor

zxkane commented Jun 24, 2024

SonarQube Quality Gate Result

Metric Status Value Error Threshold
Reliability rating ✅ OK 1 > 1
Security rating ✅ OK 1 > 1
Sqale rating ✅ OK 1 > 1
Coverage ✅ OK 83.80 < 80
Duplicated lines density ✅ OK 5.10 > 30
Blocker violations ✅ OK 0 > 0
Bugs ✅ OK 0 > 0
Code smells ✅ OK 9 > 40
Critical violations ✅ OK 0 > 0
Major violations ✅ OK 0 > 0
Vulnerabilities ✅ OK 0 > 0

View on SonarQube

updated: 6/24/2024, 08:18:07 (UTC+0)

@zxkane
Copy link
Contributor

zxkane commented Jun 24, 2024

SonarQube Code Analytics

Quality Gate passed

passed

Additional information

The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.

Issues

bug 0 Bugs

vulnerability 0 Vulnerabilities

code_smell 0 Code Smells

Coverage and Duplications

No data Coverage

No data Duplication

@zxkane zxkane changed the title fix: compatible from v1 upgrading to v2 fix: backward compatible for alb updating custom resource Jun 24, 2024
@zxkane zxkane added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 5fac5fc Jun 24, 2024
19 checks passed
@zxkane zxkane deleted the ingestion-v2-fix branch June 24, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants