Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support sending events when app move to background #21

Merged
merged 8 commits into from
Jun 25, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. add background task for sending request when app move to background.
  2. change event log to prettier format.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Jun 20, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane June 20, 2023 03:41
@zhu-xiaowei zhu-xiaowei self-assigned this Jun 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (3dfe309) 94.54% compared to head (35c0449) 94.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   94.54%   94.60%   +0.05%     
==========================================
  Files          33       33              
  Lines        1669     1686      +17     
==========================================
+ Hits         1578     1595      +17     
  Misses         91       91              
Impacted Files Coverage Δ
...ckstream/AWSClickstreamPlugin+ClientBehavior.swift 96.05% <100.00%> (ø)
...ndency/Clickstream/Analytics/AnalyticsClient.swift 100.00% <100.00%> (ø)
...pendency/Clickstream/Analytics/EventRecorder.swift 99.13% <100.00%> (+0.14%) ⬆️
...Clickstream/AutoRecord/AutoRecordEventClient.swift 93.18% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhu-xiaowei zhu-xiaowei changed the title feat: add send event when app move to background feat: support sending events when app move to background Jun 20, 2023
@zxkane zxkane merged commit ba2e4b5 into main Jun 25, 2023
@zxkane zxkane deleted the feature_background_task branch June 25, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants