-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support sending events when app move to background #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 94.54% 94.60% +0.05%
==========================================
Files 33 33
Lines 1669 1686 +17
==========================================
+ Hits 1578 1595 +17
Misses 91 91
☔ View full report in Codecov by Sentry. |
zhu-xiaowei
changed the title
feat: add send event when app move to background
feat: support sending events when app move to background
Jun 20, 2023
zxkane
requested changes
Jun 21, 2023
Sources/Clickstream/Dependency/Clickstream/Analytics/EventRecorder.swift
Outdated
Show resolved
Hide resolved
Sources/Clickstream/Dependency/Clickstream/Analytics/AnalyticsClient.swift
Outdated
Show resolved
Hide resolved
Sources/Clickstream/Dependency/Clickstream/Analytics/EventRecorder.swift
Outdated
Show resolved
Hide resolved
Sources/Clickstream/Dependency/Clickstream/Analytics/EventRecorder.swift
Outdated
Show resolved
Hide resolved
zhu-xiaowei
force-pushed
the
feature_background_task
branch
from
June 21, 2023 14:55
e71e23a
to
1758193
Compare
zxkane
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.