Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add publish script #88

Merged
merged 3 commits into from
Nov 15, 2022
Merged

build: add publish script #88

merged 3 commits into from
Nov 15, 2022

Conversation

camshaft
Copy link
Member

@camshaft camshaft commented Oct 10, 2022

This change adds a script to make publishing the crate easier. Before we committed the script.js, which could be easily forgotten to rebuild once publishing (see comment). Now we generate the script.js on demand and force a new build before publishing.

TODO

  • Build script.js in CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@camshaft camshaft mentioned this pull request Oct 10, 2022
@camshaft camshaft marked this pull request as ready for review October 10, 2022 19:31
@camshaft camshaft requested a review from a team as a code owner October 10, 2022 19:31
@camshaft camshaft marked this pull request as draft October 10, 2022 19:59
www/Makefile Show resolved Hide resolved
@camshaft camshaft marked this pull request as ready for review October 10, 2022 20:53
@camshaft camshaft requested a review from seebees October 10, 2022 20:53
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now.
Really if you have a package-lock you should use npm ci
which will use that package-lock.json to have reproducible builds.

@camshaft camshaft merged commit 1cce27d into main Nov 15, 2022
@camshaft camshaft deleted the camshaft/publish-script branch November 15, 2022 19:00
@toidiu toidiu mentioned this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants