Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add generating SHA256 checksum for Windows assets #220

Merged

Conversation

kzym-w
Copy link
Contributor

@kzym-w kzym-w commented May 1, 2024

Issue: #219

Description of changes:
This pull request adds a new step to the CI that generates checksums for the Windows executable files produced during the build process

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kzym-w kzym-w requested a review from a team as a code owner May 1, 2024 03:29
@kzym-w
Copy link
Contributor Author

kzym-w commented May 2, 2024

This is sample job's result in my fork repo.
https://github.com/kzym-w/dynein/actions/runs/8917909997

❯ ls -1
dynein-windows.zip
dynein-windows.zip.sha256

❯ sha256sum -c dynein-windows.zip.sha256
dynein-windows.zip: OK

Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for implementing this.

@kzym-w kzym-w force-pushed the add-checksum-generation-for-windows-exe branch from 09830c7 to 0bcd433 Compare May 6, 2024 14:12
Signed-off-by: Kazuki Yamamoto <kzym@amazon.com>
@kzym-w kzym-w force-pushed the add-checksum-generation-for-windows-exe branch from 0bcd433 to fd20b26 Compare May 6, 2024 14:31
@kzym-w kzym-w merged commit 22ba133 into awslabs:main May 6, 2024
3 of 4 checks passed
@kzym-w kzym-w deleted the add-checksum-generation-for-windows-exe branch May 6, 2024 14:40
KIrie-0217 pushed a commit to KIrie-0217/dynein that referenced this pull request May 15, 2024
Signed-off-by: Kazuki Yamamoto <kzym@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants