Deal with clippy warnings #7

thash · 2020-11-19T17:44:34Z

Issue #, if available: #5

Description of changes:

Fix errors/warnings detected by cargo clippy.
At the same time comment out cargo fmt check for now, to see in github workflow if the clippy warnings are correctly fixed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount

https://rust-lang.github.io/rust-clippy/master/index.html#needless_return

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else

https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit

https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports

https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref

… call https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call https://doc.rust-lang.org/std/option/enum.Option.html#method.unwrap_or > if you are passing the result of a function call, it is recommended to use unwrap_or_else, which is lazily evaluated.

https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call

https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

…ied, so no need to fill default https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern

https://rust-lang.github.io/rust-clippy/master/index.html#inefficient_to_string

https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting

https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop

…ap()` https://rust-lang.github.io/rust-clippy/master/index.html#map_clone

https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

…used after that https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap

…after clippy check passed

thash · 2020-11-27T11:58:06Z

At the same time comment out cargo fmt check for now

Now, with #12, cargo fmt check in the GitHub workflow has been enabled again.

Takuya Hashimoto added 6 commits November 20, 2020 01:24

write -> write_all

be70aa3

https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount

remove unneeded return statement

91ae5fc

https://rust-lang.github.io/rust-clippy/master/index.html#needless_return

remove redundant pattern matching. if let Some(_) -> is_some()

cb32344

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching

change &Vec<_> -> &[_] in function arguments

0b6e2ec

https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

merge identical if-else blocks

f90ab06

https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else

remove .clone() on a double-reference

c9c5df8

https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref

thash mentioned this pull request Nov 19, 2020

cargo clippy detects lots of common mistakes to be improved #5

Closed

Takuya Hashimoto added 23 commits November 21, 2020 14:14

remove redundant field names and use shorthands instead

2f33d75

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

change .len() == 0 -> .is_empty()

8482864

https://rust-lang.github.io/rust-clippy/master/index.html#len_zero

change &String -> &str

4fdd948

https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

remove redundant clone() or to_owned()

a24871e

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

remove unneeded 'static lifetime for constants

e87f7c1

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes

remove useless type conversion like i64::from(), or to_iter()

28391e7

https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

remove unused unit (()) expressions

c8af37a

https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit

remove redundant imports

e7c8a35

https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports

change .as_ref().map(<deref, or as_str etc>) to as_deref()

7b5f62c

https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref

use unwrap_or_else() instead of expect() if followed by a func call

92b3357

https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call

remove & in right hand operand

f82ea55

https://rust-lang.github.io/rust-clippy/master/index.html#op_ref

DeleteTableInput and CreateBackupInput have already all fields specif…

20abc3a

…ied, so no need to fill default https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

use 'x' (char) instead of "x" (str) for single-character strings

68392f1

https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern

dereference the receiver to avoid to call to_string() on &&str

17f3c1a

https://rust-lang.github.io/rust-clippy/master/index.html#inefficient_to_string

not to use clone() for a Copy type

59e8be2

https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

fix if-else formatting

9eead46

https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting

simplify boolean condition for if

0bffd35

https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool

remove redundant closure in map()

c5082a9

https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

use .enumerate() to remove the use of counter variable in for loop

ce721ce

https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop

use cloned() without map(), instead of the use of clone() in `m…

3357245

…ap()` https://rust-lang.github.io/rust-clippy/master/index.html#map_clone

remove unneeded format!("{}", ... on a String

32d36f9

https://rust-lang.github.io/rust-clippy/master/index.html#useless_format

use if let Some(x) instead of checking Some/None as the value x is …

38a8a2a

…used after that https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap

comment out fmt check in GitHub workflow for now, will be dealt with …

6c5b0c2

…after clippy check passed

thash force-pushed the deal_with_clippy_warnings branch from e21ec21 to 6c5b0c2 Compare November 21, 2020 07:47

thash merged commit 03700f7 into awslabs:main Nov 21, 2020

thash deleted the deal_with_clippy_warnings branch November 21, 2020 08:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deal with clippy warnings #7

Deal with clippy warnings #7

thash commented Nov 19, 2020 •

edited

Loading

thash commented Nov 27, 2020

Deal with clippy warnings #7

Deal with clippy warnings #7

Conversation

thash commented Nov 19, 2020 • edited Loading

thash commented Nov 27, 2020

thash commented Nov 19, 2020 •

edited

Loading