This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
test: add multi-tenancy integ tests #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carvantes
commented
Jul 21, 2021
rsmayda
reviewed
Jul 22, 2021
| role = 'practitioner', | ||
| providedAccessToken, | ||
| tenant = 'tenant1', | ||
| }: { role?: 'auditor' | 'practitioner'; providedAccessToken?: string; tenant?: string } = {}) => { |
There was a problem hiding this comment.
This is returning an axios instance not this custom type right?
There was a problem hiding this comment.
That's not the return type of the function. That's the type of the parameters(It gets a bit tricky due to the defaults and destructuring of params). The return type of the function is implicitly Promise<AxiosInstance>
export const getFhirClient = async ({
role = 'practitioner',
providedAccessToken,
tenant = 'tenant1',
}: { role?: 'auditor' | 'practitioner'; providedAccessToken?: string; tenant?: string } = {}) => {
...It could be specified as:
export const getFhirClient = async ({
role = 'practitioner',
providedAccessToken,
tenant = 'tenant1',
}: { role?: 'auditor' | 'practitioner'; providedAccessToken?: string; tenant?: string } = {}): Promise<AxiosInstance> => {
...There was a problem hiding this comment.
Ahh sorry yep that is right!
rsmayda
reviewed
Jul 22, 2021
rsmayda
reviewed
Jul 22, 2021
rsmayda
reviewed
Jul 22, 2021
rsmayda
suggested changes
Jul 22, 2021
rsmayda
reviewed
Jul 22, 2021
rsmayda
approved these changes
Jul 22, 2021
carvantes
added a commit
that referenced
this pull request
Aug 18, 2021
* feat: add tenantId attribute to Cognito user pool (#348) * feat: remove unneeded scope checks in authorizer (#347) * feat: update lambda state machine to accommodate tenantId (#367) * feat: add "enableMultiTenancy" CFN parameter (#381) * test: add multi-tenancy integ tests (#387) * fix: remove _id, _tenantId from bulk export results (#384) * feat: Group export scripts (#389) * fix: add multi-tenant metadata route (#392) * fix: allow more concurrent export jobs for multi-tenant deployments (#397) * test: integ tests for Group export (#393) * feat: add ES hard delete config value (#398) * docs: update postman collection and docs to use Id token (#399) * docs: add multi-tenancy docs (#400) Co-authored-by: Yanyu Zheng <yz2690@columbia.edu> BREAKING CHANGE: The Cognito IdToken is now used instead of the accessToken to authorize requests.
carvantes
added a commit
that referenced
this pull request
Aug 19, 2021
carvantes
added a commit
that referenced
this pull request
Aug 24, 2021
* feat: update lambda state machine to accommodate tenantId (#367) * feat: add "enableMultiTenancy" CFN parameter (#382) * fix: pass enableMultiTenancy to ES * fix: remove _id, _tenantId from bulk export results * feat: Group export scripts (#389) * chore: script generating patient compartment search params * feat: update Glue script for group export * Upload patient compartment jsons to S3 * fix: allow more concurrent export jobs for multi-tenant deployments (#397) * feat: add ES hard delete config value (#398) * docs: add multi-tenancy docs (#400) * fix: pass enableMultiTenancy flag to s3DataService * test: add multi-tenancy integ tests (#387) * test: integ tests for Group export (#393) * chore: upgrade dependencies * add public multi-tenant routes * add system/read and user/delete permissions to defaults * test: fix tests for smart multi-tenancy * test: update gh actions to also test multi-tenant environment * docs: update bulk export docs to mention group export Co-authored-by: Yanyu Zheng <yz2690@columbia.edu>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An env variable must be set to run the integ tests:
MULTI_TENANCY_ENABLED=true yarn int-test.This enables the tests specific to multi-tenancy and also slightly changes how the axios client is built on
getFhirClientso that all other test suites run successfully.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.