Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

test: Group export #393

Merged
merged 11 commits into from
Aug 6, 2021
Merged

test: Group export #393

merged 11 commits into from
Aug 6, 2021

Conversation

Bingjiling
Copy link
Contributor

@Bingjiling Bingjiling commented Aug 2, 2021

Issue #, if available:

Description of changes:

  • Integ test for group export

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the size/m label Aug 2, 2021
@Bingjiling Bingjiling changed the title Group export test: Group export Aug 2, 2021
Copy link
Contributor

@carvantes carvantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the tests appear to be correct. But the test setup code is a bit convoluted and can be simplified if we take advantage of advanced features of Bundle transactions (see my other comments)

integration-tests/bulkExportTestHelper.ts Outdated Show resolved Hide resolved
integration-tests/createGroupMembersBundle.json Outdated Show resolved Hide resolved
integration-tests/bulkExportTestHelper.ts Outdated Show resolved Hide resolved
integration-tests/bulkExportTestHelper.ts Outdated Show resolved Hide resolved
integration-tests/bulkExportTestHelper.ts Outdated Show resolved Hide resolved
integration-tests/bulkExport.test.ts Outdated Show resolved Hide resolved
integration-tests/bulkExportTestHelper.ts Outdated Show resolved Hide resolved
integration-tests/createGroupMembersBundle.json Outdated Show resolved Hide resolved
@Bingjiling Bingjiling merged commit ea14232 into feat-multitenancy Aug 6, 2021
@Bingjiling Bingjiling deleted the group-export branch August 6, 2021 18:32
carvantes added a commit that referenced this pull request Aug 18, 2021
* feat: add tenantId attribute to Cognito user pool (#348)

* feat: remove unneeded scope checks in authorizer (#347)

* feat: update lambda state machine to accommodate tenantId (#367)

* feat: add "enableMultiTenancy" CFN parameter  (#381)

* test: add multi-tenancy integ tests (#387)

* fix: remove _id, _tenantId from bulk export results (#384)

* feat: Group export scripts (#389)

* fix: add multi-tenant metadata route (#392)

* fix: allow more concurrent export jobs for multi-tenant deployments (#397)

* test: integ tests for Group export (#393)

* feat: add ES hard delete config value (#398)

* docs: update postman collection and docs to use Id token  (#399)

* docs: add multi-tenancy docs (#400)


Co-authored-by: Yanyu Zheng <yz2690@columbia.edu>

BREAKING CHANGE: The Cognito IdToken is now used instead of the accessToken to authorize requests.
carvantes pushed a commit that referenced this pull request Aug 19, 2021
carvantes added a commit that referenced this pull request Aug 24, 2021
* feat: update lambda state machine to accommodate tenantId (#367)

* feat: add "enableMultiTenancy" CFN parameter (#382)

* fix: pass enableMultiTenancy to ES

* fix: remove _id, _tenantId from bulk export results

* feat: Group export scripts (#389)

* chore: script generating patient compartment search params

* feat: update Glue script for group export

* Upload patient compartment jsons to S3

* fix: allow more concurrent export jobs for multi-tenant deployments (#397)

* feat: add ES hard delete config value (#398)

* docs: add multi-tenancy docs (#400)

* fix: pass enableMultiTenancy flag to s3DataService

* test: add multi-tenancy integ tests (#387)

* test: integ tests for Group export (#393)

* chore: upgrade dependencies

* add public multi-tenant routes

* add system/read and user/delete permissions to defaults

* test: fix tests for smart multi-tenancy

* test: update gh actions to also test multi-tenant environment

* docs: update bulk export docs to mention group export

Co-authored-by: Yanyu Zheng <yz2690@columbia.edu>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants