This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
docs: update postman collection and docs to use Id token #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carvantes
changed the title
Bingjiling
reviewed
Aug 10, 2021
There was a problem hiding this comment.
Looks good, a few other places might need change as well:
GitHub workflow: https://github.com/awslabs/fhir-works-on-aws-deployment/blob/feat-multitenancy/.github/workflows/deploy.yaml#L136
Install script: https://github.com/awslabs/fhir-works-on-aws-deployment/blob/feat-multitenancy/scripts/install.sh#L318
Bingjiling
approved these changes
Aug 11, 2021
2 tasks
carvantes
added a commit
that referenced
this pull request
Aug 18, 2021
* feat: add tenantId attribute to Cognito user pool (#348) * feat: remove unneeded scope checks in authorizer (#347) * feat: update lambda state machine to accommodate tenantId (#367) * feat: add "enableMultiTenancy" CFN parameter (#381) * test: add multi-tenancy integ tests (#387) * fix: remove _id, _tenantId from bulk export results (#384) * feat: Group export scripts (#389) * fix: add multi-tenant metadata route (#392) * fix: allow more concurrent export jobs for multi-tenant deployments (#397) * test: integ tests for Group export (#393) * feat: add ES hard delete config value (#398) * docs: update postman collection and docs to use Id token (#399) * docs: add multi-tenancy docs (#400) Co-authored-by: Yanyu Zheng <yz2690@columbia.edu> BREAKING CHANGE: The Cognito IdToken is now used instead of the accessToken to authorize requests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Multi-tenancy requires the use of the Cognito
IdTokeninstead of theAccessTokensince only theIdTokencan have custom claims to store thetenantId.We updated the default single-tenant deployment to also use the
IdTokensince maintaining support for both token types adds complexity.The postman collection was reverted to using the
COGNITO_AUTH_TOKEN(which means running a script and copying the token into postman). It was possible to signin to Cognito from postman and get an access token, but postman makes it impossible to use the Id Token that way. See: postmanlabs/postman-app-support#492, postmanlabs/postman-app-support#8231By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.