Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git secrets --scan on repo where files have spaces in their names fails #5

Closed
mtdowling opened this issue Dec 17, 2015 · 0 comments
Closed
Labels

Comments

@mtdowling
Copy link
Contributor

This results in treating each space delimited segment of the filename as a separate file, causing file not found errors with grep.

When calling --scan with no arguments, we scan all files returned by git ls-files. We might need to re-think this or to escape these filenames when passing them to grep. We could also look into using git grep in this case.

@mtdowling mtdowling added the bug label Jan 6, 2016
mtdowling added a commit that referenced this issue Jan 11, 2016
As an alternative to using xargs, we'll use `git grep` to grep the files
present in a repository. This allows us to quickly scan files in the
repo and properly work with files that contain spaces in the name.

Closes #5
Closes #6
Closes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant