-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating pydantic to 0.28
.
#108
Conversation
Fixes #107. Between 0.12 (the last version we used) and 0.28, pydantic * changed `get_validators` to `__get_validators__` * prevents us from using the `fields` attribute on models Fixing doctest. Also, increasing TOL for flaky tests.
Job PR-108/3 is complete. |
@@ -46,7 +46,7 @@ | |||
|
|||
NUM_SAMPLES = 2000 | |||
BATCH_SIZE = 32 | |||
TOL = 0.2 | |||
TOL = 0.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is @jaheba saying “enough!”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is a good idea. Maybe we should instead disable the flaky test for now as a reminder that someone should look into it? With 30% relative tolerance (which now also applies to all other distribution test), we are not really testing much anymore, anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, let me add an issue for that.
Fixes #107.
Between 0.12 (the last version we used) and 0.28, pydantic
get_validators
to__get_validators__
fields
attribute on modelsIssue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.