Fix ev.seasonal_error
#2696
Merged
Fix ev.seasonal_error
#2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
added
bug fix
jaheba
approved these changes
Feb 27, 2023
Comment on lines
+26
to
+27
| if seasonality > time_length: | ||
| seasonality = 1 |
There was a problem hiding this comment.
I still find this somewhat odd.
melopeo
pushed a commit
to melopeo/gluon-ts
that referenced
this pull request
Mar 14, 2023
Merged
melopeo
added a commit
that referenced
this pull request
Mar 15, 2023
* Fix `ev.seasonal_error` (#2696) * Docs: minor spelling fix (#2701) * Fix Pandas 2.0 compatibility issues (#2710) * Relax pandas requirement to include pandas 2.x. (#2713) * Fix DistributionForecast failure on GPU (#2714) * file style in init files --------- Co-authored-by: Lorenzo Stella <stellalo@amazon.com> Co-authored-by: Jasper <schjaspe@amazon.de> Co-authored-by: Huibin Shen <icdishb@gmail.com> Co-authored-by: Pedro Eduardo Mercado Lopez <pedroml@amazon.com>
melopeo
removed
the
pending v0.12.x backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: See discussion in #2673
Description of changes: Time axis was inconsistent within
gluonts.ev.seasonal_error, this makes it consistent (and configurable, and more compact).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup