Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lost freq of pandas timestamp #79

Merged
merged 1 commit into from
Jun 6, 2019
Merged

fix lost freq of pandas timestamp #79

merged 1 commit into from
Jun 6, 2019

Conversation

vafl
Copy link
Contributor

@vafl vafl commented Jun 5, 2019

Issue #, if available:

Fixes #78

Description of changes:

Fix lost frequency in pandas timestamp

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@szha
Copy link
Member

szha commented Jun 5, 2019

Job PR-79/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-79/1/index.html

@alexw91
Copy link
Member

alexw91 commented Jun 5, 2019

Codecov Report

Merging #79 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage    78.6%   78.61%   +<.01%     
==========================================
  Files         110      110              
  Lines        6278     6279       +1     
==========================================
+ Hits         4935     4936       +1     
  Misses       1343     1343
Impacted Files Coverage Δ
src/gluonts/transform.py 81.49% <100%> (+0.04%) ⬆️

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug in pandas?

@benidis
Copy link
Contributor

benidis commented Jun 5, 2019

I reproduced the error downloading the quandl dataset and following the code. I was ready to push the fix and then I saw that Valentin had already fixed it!

I think it is a pandas bug.

BTW m4_monthly and m4_weekly do not run for exactly this reason. This may explain a lot about the overall m4 results.

@vafl
Copy link
Contributor Author

vafl commented Jun 6, 2019

@lostella Yes, I suspect it broke in a recent version of pandas. I'll check and perhaps submit an issue.

@vafl vafl merged commit 2de36e0 into awslabs:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Working with Weekly or Montly time series
5 participants