Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data incorrectly pushed to series-connector #153

Closed
janezhang10 opened this issue Jul 8, 2022 · 1 comment
Closed

Data incorrectly pushed to series-connector #153

janezhang10 opened this issue Jul 8, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@janezhang10
Copy link

Describe the bug
Data is being pushed upon every Live tick to iot-time-series-connector when in Live mode. The prevDataCache for hasRequestedInformationChanged() is sometimes undefined, which causes hasRequestedInformationChanged to always return true.

To Reproduce
Steps to reproduce the behavior:

  1. Have a working testing-ground with working assetIds
  2. Produce a time series chart with duration '1m' (preferably line chart so that the data is aggregated compared to scatter)
  3. Have some console logs in hasRequestedInformationChanged that details prevDataStreamStore
  4. Run the App Kit locally and inspect the page
  5. See that prevDataStreamStore is occasionally undefined in console

Expected behavior
Only new incoming data should be pushed to iot-time-series-connector in Live mode. hasRequestedInformationChanged should only return true if there's new incoming data that needs to be rendered, and prevDataCache should only be undefined upon initialization of DataCache.

Screenshots
example of prevDataStreamStore being undefined while currDataStreamStore is defined after letting App Kit run locally for a while.
Screen Shot 2022-07-08 at 3 59 35 PM
Screen Shot 2022-07-08 at 4 00 38 PM

Desktop (please complete the following information):

  • OS: macOS Monterey
  • Browser Firefox
  • Version 91.10.0esr

Additional context
The frequency of prevDataCache being undefined depends on the duration of the viewport. The smaller the duration (e.g. 1 minute), the more often prevDataCache is undefined (about every other tick).

@janezhang10 janezhang10 added the bug Something isn't working label Jul 8, 2022
@diehbria diehbria assigned diehbria and NorbertNader and unassigned diehbria Nov 16, 2022
@NorbertNader NorbertNader modified the milestone: Dashboard Dec 1, 2022
@NorbertNader
Copy link
Contributor

This issue no longer exists in latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants