styleSettings API introduction #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehbria
force-pushed
the
styles-types
branch
3 times, most recently
from
e091533
to
8919be1
Compare
boweihan
reviewed
Jan 24, 2022
| @@ -37,7 +41,7 @@ export class IotConnector { | |||
| request: this.request, | |||
| }, | |||
| (dataStreams: DataStream[]) => { | |||
| this.dataStreams = dataStreams; | |||
| this.dataStreams = bindStylesToDataStreams({ dataStreams, styleSettings: this.styleSettings }); | |||
There was a problem hiding this comment.
(random thoughts) It initially felt strange to me to bind style to dataStreams, since styles are metadata and not streamed. I see that it follows the synchro-chart API though, and these are essentially DataStreamStyles. Would we ever want to swap out synchro-charts as a viz library? If not then this approach seems fine.
There was a problem hiding this comment.
how we bind styleSettings will be component specific, right now iot-connector is a bit specific to Synchro Charts, but we can refactor it as necessary as the need arises as iot-connector is purely an internal helper and not intended to be used as part of the offerings of the library
diehbria
force-pushed
the
styles-types
branch
from
8919be1
to
437dba9
Compare
diehbria
force-pushed
the
styles-types
branch
2 times, most recently
from
1cf3b19
to
73b7b07
Compare
diehbria
force-pushed
the
styles-types
branch
from
73b7b07
to
b07a193
Compare
boweihan
approved these changes
Jan 24, 2022
sheilaXu
added a commit
that referenced
this pull request
Sep 23, 2022
Co-authored-by: Xinyi Xu <xinyxu@amazon.com>
TheEvilDev
pushed a commit
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implementation of
styleSettings, which uses therefIdpresent in data streams to provide presentational settings to components.Refactored the api from
styles->styleSettings, as stencil ignores the propstyles. Likely is a reserved keyword that you cannot pass an object into.Legal
This project is available under the Apache 2.0 License.