Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent stream render if dataType unknown #448

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

corteggiano
Copy link
Contributor

@corteggiano corteggiano commented Dec 29, 2022

Overview

graphs would flicker between the unsupported data warning and the empty graph state due to incomplete data being sent to synchroCharts widget. this prevents this by only rendering data that has a set dataType

#405

Legal

This project is available under the Apache 2.0 License.

@corteggiano corteggiano changed the title bug: prevent stream render if dataType unknown fix: prevent stream render if dataType unknown Dec 29, 2022
@corteggiano corteggiano linked an issue Dec 29, 2022 that may be closed by this pull request
NorbertNader
NorbertNader previously approved these changes Dec 29, 2022
tjuranek
tjuranek previously approved these changes Jan 5, 2023
tjuranek
tjuranek previously approved these changes Jan 9, 2023
@corteggiano corteggiano merged commit 16999db into awslabs:main Jan 9, 2023
@corteggiano corteggiano deleted the sitewise-bools-strings branch January 9, 2023 21:27
@github-actions github-actions bot mentioned this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SiteWise datasource: Improved boolean / string support
3 participants