Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port unit-tests to main and generate tests #120

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ryansteakley
Copy link
Contributor

@ryansteakley ryansteakley commented Mar 4, 2022

Description of your changes:
Port over unit-tests to the main branch and generate tests for the applicable manifests found in the awsconfigs/common directory.

  • Add directories of the kustomization packages we are modifiyng/own to generate_test.py
  • Run these new generated tests in tests/unit-tests/Makefile
  • Non-auto generated files
    • generate_tests.py
    • Makefile
    • test_util.py
      Checklist:
  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

Copy link
Contributor

@surajkota surajkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking long to review even if I leave out the test_data/expected need more time to ramp up

if we are using the same framework as upstream, I am wondering if it is possible to keep only the diff here. Integration tests and overlays depend on the upstream repo to be available locally, Can we use the same approach and only keep a diff we own?

@surajkota
Copy link
Contributor

surajkota commented Mar 9, 2022

PR mentions awsconfigs/common. will tests for awsconfigs/apps be a separate PR? It will be good to keep it separate

@ryansteakley
Copy link
Contributor Author

PR mentions awsconfigs/common. will tests for awsconfigs/apps be a separate PR? It will be good to keep it separate

Yes, it will be a separate pr, this was to port things under common since they are all aws related.

@mbaijal
Copy link
Contributor

mbaijal commented Mar 14, 2022

Can you link to the original PR in the description since that PR had easier to read diffs for reference.

Copy link
Contributor

@mbaijal mbaijal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this is a copy of the previous PRs changes with path changes.

@ryansteakley ryansteakley merged commit d7c55da into awslabs:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants