Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance cognito deployment automation scripts #130

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

surajkota
Copy link
Contributor

@surajkota surajkota commented Mar 11, 2022

Description of your changes:

  • Enhance cognito automation script to include ingress and alb controller configuration
  • Removed CNAME entry for *.default.example.com since it is not needed. From what I understand we only need kubeflow.platform.example.com and not even *.platform.example.com since all the apps are paths under the domain name. e.g. platform.example.com/pipelines
  • Add badges to the README for customers to easily identify which Kubeflow version is under development. Open to other suggestions
    • Updated PR template to include license attribution
  • Resolves: Should users be allowed to sign themselves up using Cognito hosted UI #122
    • made email as a option to use as username instead of having email only or username only
    • Disable self signup - only admins can create users
    • Make email a required attribute and add corresponding documentation
  • updated e2e test readme
  • fixed logging issues in e2e tests using the pytest.ini config. It was not printing logging logs and also some of the print statements
  • fixed issue with ingress and load balancer cleanup in the cognito e2e test. deleting ingress is clean way to remove the ingress managed load balancer. Using cognito_resource_cleanup was leaving around some resources

Testing:

  • e2e tests pass
  • Manually tested cognito automation README

@ryansteakley
Copy link
Contributor

Great work, just a few questions. Allowed only the admin to create accounts seems fine to me, seems like it also prevents the url from leaking and having someone sign up themselves thousands of times maliciously. However what is the reasoning for requiring the email field however?

@surajkota
Copy link
Contributor Author

surajkota commented Mar 15, 2022

@ryansteakley good catch. I have updated the README with missing documentation from automation and related to email field.

@surajkota surajkota mentioned this pull request Mar 15, 2022
31 tasks
@surajkota surajkota merged commit a43e923 into awslabs:main Mar 16, 2022
judyheflin pushed a commit to judyheflin/kubeflow-manifests that referenced this pull request Apr 20, 2022
…021-09-22

Add navbar_translucent_over_cover_disable and sort ui elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should users be allowed to sign themselves up using Cognito hosted UI
3 participants