-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance cognito deployment automation scripts #130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great work, just a few questions. Allowed only the admin to create accounts seems fine to me, seems like it also prevents the url from leaking and having someone sign up themselves thousands of times maliciously. However what is the reasoning for requiring the email field however? |
4 tasks
@ryansteakley good catch. I have updated the README with missing documentation from automation and related to email field. |
ryansteakley
approved these changes
Mar 15, 2022
31 tasks
rrrkharse
approved these changes
Mar 15, 2022
ryansteakley
approved these changes
Mar 16, 2022
judyheflin
pushed a commit
to judyheflin/kubeflow-manifests
that referenced
this pull request
Apr 20, 2022
…021-09-22 Add navbar_translucent_over_cover_disable and sort ui elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
*.default.example.com
since it is not needed. From what I understand we only needkubeflow.platform.example.com
and not even*.platform.example.com
since all the apps are paths under the domain name. e.g.platform.example.com/pipelines
pytest.ini
config. It was not printing logging logs and also some of the print statementsTesting: