Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning during attribution docs generation - "failed to validate all files specified in clarification" #786

Closed
dannycjones opened this issue Feb 26, 2024 · 0 comments · Fixed by #788
Closed

Warning during attribution docs generation - "failed to validate all files specified in clarification" #786

dannycjones opened this issue Feb 26, 2024 · 0 comments · Fixed by #788
Labels
dependencies Pull requests that update a dependency file tests or CI Issues requiring new tests or CI

Comments

@dannycjones
Copy link
Contributor

The attribution documentation is generated OK but we need to modify the clarification it would seem. If possible, this should be blocking new commits.

https://github.com/awslabs/mountpoint-s3/actions/runs/7669877297/job/20904772899#step:5:426

2024-01-26 15:19:41.889238016 +00:00:00 [WARN] failed to validate all files specified in clarification for crate zerocopy 0.7.31: unable to read path '/root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zerocopy-0.7.31/LICENSE'
2024-01-26 15:19:41.889330729 +00:00:00 [WARN] failed to validate all files specified in clarification for crate zerocopy-derive 0.7.31: unable to read path '/root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zerocopy-derive-0.7.31/LICENSE'

Packages impacted:

  • zerocopy-0.7.31
  • zerocopy-derive-0.7.31

These are the defined clarifications which need some review:

mountpoint-s3/package/attribution.toml

Lines 24 to 34 in 6d7c194

[zerocopy.clarify]
license = "BSD-2-Clause"
[[zerocopy.clarify.files]]
path = "LICENSE"
checksum = "83c1763356e822adde0a2cae748d938a73fdc263849ccff6b27776dff213bd32"
[zerocopy-derive.clarify]
license = "BSD-2-Clause"
[[zerocopy-derive.clarify.files]]
path = "LICENSE"
checksum = "83c1763356e822adde0a2cae748d938a73fdc263849ccff6b27776dff213bd32"

@dannycjones dannycjones added dependencies Pull requests that update a dependency file tests or CI Issues requiring new tests or CI labels Feb 26, 2024
jamesbornholt added a commit to jamesbornholt/mountpoint-s3 that referenced this issue Feb 26, 2024
@jamesbornholt
Remove license clarification for zerocopy
338adc3 
This isn't needed after google/zerocopy#542

Fixes awslabs#786.

Signed-off-by: James Bornholt <bornholt@amazon.com>
@jamesbornholt jamesbornholt mentioned this issue Feb 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2024
@jamesbornholt
Remove license clarification for zerocopy (#788)
5ce4863 
This isn't needed after google/zerocopy#542

Fixes #786.

Signed-off-by: James Bornholt <bornholt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file tests or CI Issues requiring new tests or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove license clarification for zerocopy jamesbornholt/mountpoint-s3
1 participant
@dannycjones