Add bulk magnetic field energy postprocessing #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangrimberg
added
enhancement
sebastiangrimberg
force-pushed
the
sjg/domain-postpro-energy
branch
from
9736e50
to
11ac368
Compare
sebastiangrimberg
changed the base branch from
main
to
sjg/eigenmode-port-postpro
sebastiangrimberg
force-pushed
the
sjg/eigenmode-port-postpro
branch
3 times, most recently
from
e313a33
to
59bd14f
Compare
sebastiangrimberg
force-pushed
the
sjg/domain-postpro-energy
branch
from
11ac368
to
25a277e
Compare
sebastiangrimberg
force-pushed
the
sjg/domain-postpro-energy
branch
from
25a277e
to
436ffc3
Compare
sebastiangrimberg
force-pushed
the
sjg/domain-postpro-energy
branch
2 times, most recently
from
db6f96e
to
5256ace
Compare
hughcars
reviewed
Nov 20, 2023
palace/models/domainpostoperator.hpp
Outdated
| // Access underlying bulk loss postprocessing data structures (for keys). | ||
| const auto &GetEps() const { return M_NDi; } | ||
| auto SizeEps() const { return M_NDi.size(); } | ||
| // Access data structures for the postprocessing the domain with the given type. |
There was a problem hiding this comment.
I think one of those "the" is an error.
| @@ -91,13 +91,10 @@ class SurfacePostOperator | |||
| SurfacePostOperator(const IoData &iodata, const MaterialOperator &mat_op, | |||
| mfem::ParFiniteElementSpace &h1_fespace); | |||
|
|
|||
| // Access data structures for the postprocessing surface with the given type. | |||
| // Access data structures for the postprocessing the surface with the given type. | |||
There was a problem hiding this comment.
I think one of those "the" is an error.
docs/src/examples/cavity.md
Outdated
Comment on lines
77
to
78
| [`config["Domains"]["Postprocessing"]["Bulk]"`] | ||
| (../config/domains.md#domains["Postprocessing"]["Energy"]) object is used to extract the |
There was a problem hiding this comment.
The link there is from Bulk to Energy, whereas they were previously both Dielectric, is the name mismatch on purpose?
docs/src/config/domains.md
Outdated
|
|
||
| `"Attributes" [None]` : Integer array of mesh domain attributes for this lossy domain. | ||
| `"Attributes" [None]` : Integer array of mesh domain attributes for this bulk domain. |
There was a problem hiding this comment.
Does it need bulk here? Is this differentiating from a non-bulk (I guess a surface?) domain?
palace/models/domainpostoperator.hpp
Outdated
Comment on lines
46
to
48
| // Get volume integrals for bulk electric or magnetic field energy in a portion of the | ||
| // domain. |
There was a problem hiding this comment.
"for the electric or magnetic" to match above? Or is there an extra meaning to bulk I am missing?
sebastiangrimberg
force-pushed
the
sjg/domain-postpro-energy
branch
from
72da1f2
to
ab41bb4
Compare
…energies for the desired regions (from which the participation ratios, quality factors, etc. can be computed by the user)
sebastiangrimberg
force-pushed
the
sjg/domain-postpro-energy
branch
from
ab41bb4
to
038f919
Compare
hughcars
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config["Domains"]["Postprocessing"]["Dielectric"]is replaced byconfig["Domains"]["Postprocessing"]["Energy"]to output both the electric and magnetic field energies in certain parts of the domain. The previous functionality (electric field participation ratios, loss factors) are all still available using the data indomain-E.csv.TODO: Depends on #129