Fix oriented bounding box calculation for lumped ports, in preparation for #261 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangrimberg
added
bug
sebastiangrimberg
force-pushed
the
sjg/lumped-ports-bbox
branch
from
f803981
to
aa9cca8
Compare
sebastiangrimberg
force-pushed
the
sjg/mesh-simplex-dev
branch
from
24fc0d8
to
77cbc97
Compare
sebastiangrimberg
force-pushed
the
sjg/lumped-ports-bbox
branch
from
aa9cca8
to
aefb44c
Compare
hughcars
reviewed
Jun 26, 2024
hughcars
approved these changes
Jun 26, 2024
…eed to calculate width from area, as previously)
sebastiangrimberg
force-pushed
the
sjg/lumped-ports-bbox
branch
from
2060846
to
a6e8725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor perturbations to a perfect quadrilateral or rectangular prism caused the entire algorithm to fail and led to failed
MFEM_VERIFYstatements for the direction inUniformElementData's constructor.