-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tutorial about domain adaptation, including LHUC #409
Conversation
This is a nice use case for the recently introduced config files. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding!
tutorials/adapt/README.md
Outdated
this tutorial, we show two methods on how to perform domain adaptation of a | ||
general translation system using Sockeye. | ||
|
||
We assume you already have an already trained Sockeye model, for example the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'we assume you already have a trained Sockeye model'
tutorials/adapt/README.md
Outdated
general translation system using Sockeye. | ||
|
||
We assume you already have an already trained Sockeye model, for example the | ||
one trained in the [second tutorial](../wmt/README.md). We also assume that you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'for example from the second tutorial.'
tutorials/adapt/README.md
Outdated
|
||
We assume you already have an already trained Sockeye model, for example the | ||
one trained in the [second tutorial](../wmt/README.md). We also assume that you | ||
have two training sets, one composed of general or out-of-domain data, and one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if would introduce the abbreviations you use below here ('id' and 'ood')
tutorials/adapt/README.md
Outdated
|
||
## Continuation of training | ||
|
||
This method consists in taking the parameters of an already trained system and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just: 'This method fine-tunes a trained model and starts a second training run on in-domain data, initialized with the parameters obtained from the out-domain data.'
tutorials/adapt/README.md
Outdated
This method consists in taking the parameters of an already trained system and | ||
use them as initialization of a new training run only on the in-domain data. | ||
Thus you "continue training" on the data you are more interested in. Freitag | ||
and Al-Onaizan (2016) showed that, while being quite a straightforward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a "# references" section at the bottom with the full citation.
tutorials/adapt/README.md
Outdated
use them as initialization of a new training run only on the in-domain data. | ||
Thus you "continue training" on the data you are more interested in. Freitag | ||
and Al-Onaizan (2016) showed that, while being quite a straightforward | ||
technique, this method can achieve good results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'showed that this straightforward technique can achieve good results.'
tutorials/adapt/README.md
Outdated
|
||
## Leaning Hidden Unit Contribution | ||
|
||
Leaning Hidden Unit Contribution (LHUC) is a method proposed by Vilar (2018), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: leaning -> learning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
full citation at the bottom maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Included tutorial about adapting NMT models, including LHUC.
Pull Request Checklist
until you can check this box.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.