Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature multi select #176

Merged
merged 11 commits into from
Mar 18, 2024
Merged

Feature multi select #176

merged 11 commits into from
Mar 18, 2024

Conversation

ChrisPates
Copy link
Contributor

@ChrisPates ChrisPates commented Mar 18, 2024 •
edited
Loading

Issue #, if available:
#156, #136, #101, #69, #66, #34, #28

Description of changes:

  • now support multiple group prefixes in groupMatch parameter
  • supports both group and user match in combination.
    • '*' - matches all
    • '' - do not perform match
    • 'single or multi match patterns' - as defined
  • Above feature makes it easier to specify specific groups or users to include.
  • nested groups now supported by 'flattening' nesting into the top level group
  • external users correctly identified and excluded from syncs
  • owner role in groups explicitly ignored as no equivalent exists in IAM Identity Center

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ChrisPates
Implement multi-pattern support for groups and users
07e9f75
@ChrisPates
adjust regex for multi-pattern
10e1ce6
@ChrisPates
Allow - and ' ' in names
1f131b7
@ChrisPates
UPDATE envVar creation logic for Match
7b2affd
@ChrisPates
Update template.yaml
186dc62
@ChrisPates
Update template.yaml
cc3b9a8
@ChrisPates
Adding support for '*' to sync all and empty to sync nothing.
630d558
@ChrisPates
Improvements to Filtering
12b80a8 
UserMatch now considered in addition to GroupMatch.

Improved filtering for external users
proper handling of nested groups.
@ChrisPates
Improve logging
ec01d9a 
Added dump of envVars
Corrected copy&paste error in log message.
@ChrisPates
Adding user detail caching
c067fd6 
To reduce repeated calls to the directory api, prefetch all users and use when processing groups.
@ChrisPates
Update README.md
4e7f800
@ChrisPates ChrisPates added this to the v2.2 milestone Mar 18, 2024
@ChrisPates ChrisPates self-assigned this Mar 18, 2024
@ChrisPates ChrisPates merged commit d9ab40b into master Mar 18, 2024
1 check passed
@ChrisPates ChrisPates deleted the Feature_multi_select branch March 18, 2024 18:54
@ChrisPates ChrisPates restored the Feature_multi_select branch March 21, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ChrisPates ChrisPates

Labels
None yet
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
1 participant
@ChrisPates