Enable windows and macos builds in CI #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also disables Rust incremental builds in the CI for a few reasons: * Incremental builds need a lot of disk space, which we need to protect for Windows builds. * Only the first invocation for each cache key is stored, so the delta between incremental builds grows larger over time. See dtolnay/rust-toolchain#26 for more details.
Using `std::path::Path` to manipulate `Url` paths only has the correct behavior on unix systems where the properties of the paths are nearly identical. This change moves to using unix-style path manipulation regardless of platform. It also adds a utility for safely creating filesystem paths based on `Url` paths for both unix and windows (which is complicated by drive lettering in absolute paths).
Github actions on Windows do not allow running Linux containers. In order to run the same CI on Windows as Linux, we compile toxic HTTP services at test time.
This was referenced Aug 23, 2023
The forked noxious-server takes a little longer to start on MacOS. Using retries ensures we keep trying until the server is ready.
cbgbt
changed the title
ecpullen
approved these changes
Aug 24, 2023
| # https://github.com/oguzbilgener/noxious/pull/14 | ||
| .PHONY: noxious | ||
| noxious: | ||
| cargo install --locked --git https://github.com/cbgbt/noxious.git --tag v1.0.5 |
There was a problem hiding this comment.
Can we add a tracking issue to make sure we don't forget about this fork.
There was a problem hiding this comment.
Yes, I opened one here: #671
bcressey
approved these changes
Aug 24, 2023
|
Thanks @chipsenkbeil for help with chipsenkbeil/typed-path#8, which made this much easier than it could have been. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes: #349
Closes: #347
Closes: #663
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.