Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump url from 2.4.1 to 2.5.0 #724

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 23, 2023

Bumps url from 2.4.1 to 2.5.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 23, 2023
Bumps [url](https://github.com/servo/rust-url) from 2.4.1 to 2.5.0.
- [Release notes](https://github.com/servo/rust-url/releases)
- [Commits](servo/rust-url@v2.4.1...v2.5.0)

---
updated-dependencies:
- dependency-name: url
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/url-2.5.0 branch from 82fd387 to d9136bb Compare December 6, 2023 18:33
@cbgbt cbgbt self-requested a review December 11, 2023 18:17
@cbgbt
Copy link
Contributor

cbgbt commented Dec 11, 2023

Hmm, odd that one of the tuftool tests failed on macos. Here's the relevant output for when the test logs are pruned:

running 4 tests
test clone_metadata_target_args_failure ... ok
test clone_full_repo ... ok
test clone_metadata ... FAILED
test clone_subset_targets ... ok

failures:

---- clone_metadata stdout ----
thread 'clone_metadata' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"{\n \"signatures\": [\n  {\n   \"keyid\": \"4e777de0d275f9d28588dd9a1606cc748e548f9e22b6795b7cb

And this is the assertion that failed. I'm going to re-run the test while I peek at that code.

@webern
Copy link
Contributor

webern commented Dec 11, 2023

I opened an issue: #734

@cbgbt
Copy link
Contributor

cbgbt commented Jan 11, 2024

After reading through the test source, I'm convinced that the issue is almost certainly some sort of filesystem/IO issue and couldn't possibly be related to a URL bump. I'm going to merge this PR.

@cbgbt cbgbt merged commit b5eb017 into develop Jan 11, 2024
7 checks passed
@cbgbt cbgbt deleted the dependabot/cargo/url-2.5.0 branch January 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants