Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes table formatting issue #517

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Fixes table formatting issue #517

merged 4 commits into from
Sep 20, 2022

Conversation

rajadilipkolli
Copy link
Contributor

Currently table is distorted, fixed it

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes table format issue

💡 Motivation and Context

💚 How did you test it?

checked the format in preview

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

Currently table is distorted, fixed it
@github-actions github-actions bot added the type: documentation Documentation or Samples related issue label Sep 11, 2022
@maciejwalkowiak
Copy link
Contributor

Thanks! It renders better but still not perfect
image
Would you be interested in trying to making it look like a regular table with two equal column with 100% width?

@rajadilipkolli
Copy link
Contributor Author

rajadilipkolli commented Sep 12, 2022 via email

@maciejwalkowiak
Copy link
Contributor

@rajadilipkolli
Copy link
Contributor Author

@maciejwalkowiak Are you ok with the auto width now?

@maciejwalkowiak
Copy link
Contributor

Still does not look 100% correct but perhaps it's an issue with Asciidoctor itself. I'll merge as it better than it used to be. Thanks @rajadilipkolli !

@maciejwalkowiak maciejwalkowiak merged commit 9aaaa88 into awspring:main Sep 20, 2022
@rajadilipkolli rajadilipkolli deleted the patch-1 branch September 20, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation or Samples related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants