Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanups #142

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Test cleanups #142

merged 5 commits into from
Sep 28, 2022

Conversation

lukasmalkmus
Copy link
Collaborator

This PR performs mostly code grooming. It resolves some outstanding TODOs, improves GoDoc, makes testing for adapters simpler and does some smaller cleanups in test files.

Needs #141.

@lukasmalkmus lukasmalkmus enabled auto-merge (rebase) September 26, 2022 16:38
@lukasmalkmus lukasmalkmus self-assigned this Sep 26, 2022
@lukasmalkmus lukasmalkmus added this to the v0.13.0 milestone Sep 26, 2022
@lukasmalkmus lukasmalkmus added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 72.20% // Head: 71.22% // Decreases project coverage by -0.98% ⚠️

Coverage data is based on head (825bd65) compared to base (643f6e2).
Patch coverage: 70.92% of modified lines in pull request are covered.

❗ Current head 825bd65 differs from pull request most recent head 845cb93. Consider uploading reports for the commit 845cb93 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   72.20%   71.22%   -0.99%     
==========================================
  Files          36       42       +6     
  Lines        1684     1835     +151     
==========================================
+ Hits         1216     1307      +91     
- Misses        353      399      +46     
- Partials      115      129      +14     
Impacted Files Coverage Δ
adapters/apex/apex.go 77.06% <ø> (-0.42%) ⬇️
adapters/logrus/logrus.go 74.57% <ø> (-0.43%) ⬇️
axiom/error.go 64.70% <ø> (ø)
axiom/axiom.go 50.00% <40.00%> (-30.00%) ⬇️
internal/config/defaults.go 42.85% <42.85%> (ø)
axiom/otel/trace_config.go 53.84% <53.84%> (ø)
axiom/otel/trace.go 70.37% <70.37%> (ø)
axiom/client.go 81.25% <72.22%> (-3.48%) ⬇️
internal/config/option.go 72.72% <72.72%> (ø)
internal/config/config.go 77.77% <77.77%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@bahlo bahlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Removed TODOs that referred to implementing a retry mechanism. That is now in place on a http-level for the axiom-go client.
The other adapters use zstd over gzip, as well, as they use the 'IngestEvents' method which prefers zstd over gzip.
@github-actions
Copy link

This PR/issue depends on:

@lukasmalkmus lukasmalkmus merged commit 6bc3e9e into main Sep 28, 2022
@lukasmalkmus lukasmalkmus deleted the lukasmalkmus/test-cleanups branch September 28, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants