-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cleanups #142
Test cleanups #142
Conversation
Codecov ReportBase: 72.20% // Head: 71.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 72.20% 71.22% -0.99%
==========================================
Files 36 42 +6
Lines 1684 1835 +151
==========================================
+ Hits 1216 1307 +91
- Misses 353 399 +46
- Partials 115 129 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Removed TODOs that referred to implementing a retry mechanism. That is now in place on a http-level for the axiom-go client.
The other adapters use zstd over gzip, as well, as they use the 'IngestEvents' method which prefers zstd over gzip.
825bd65
to
845cb93
Compare
This PR/issue depends on:
|
This PR performs mostly code grooming. It resolves some outstanding
TODOs
, improves GoDoc, makes testing for adapters simpler and does some smaller cleanups in test files.Needs #141.