Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding isAxiosError flag to errors thrown by axios #1419

Merged
merged 4 commits into from Aug 20, 2018

Conversation

@AyushG3112
Copy link
Contributor

@AyushG3112 AyushG3112 commented Mar 15, 2018

Adding a isAxiosError flag in errors thrown by axios.

This PR aims to resolve the issue posed by #1415 while preventing breaking changes.

@cruelbob
Copy link

@cruelbob cruelbob commented Aug 20, 2018

@AyushG3112 Can you resolve conflicts?
@axe312ger, @Khaledgarbaya

Loading

@axe312ger
Copy link
Contributor

@axe312ger axe312ger commented Aug 20, 2018

Maybe as well @RikkiGibson and @emilyemorehouse

Loading

Copy link
Contributor

@axe312ger axe312ger left a comment

LGTM, this will ease up correct error detection a lot :)

Loading

@Khaledgarbaya
Copy link
Collaborator

@Khaledgarbaya Khaledgarbaya commented Aug 20, 2018

I resolved the conflict @cruelbob @AyushG3112, overall I agree with this change. I will try to merge asap

Loading

Copy link
Contributor

@axe312ger axe312ger left a comment

Still LGTM

Loading

Copy link
Collaborator

@Khaledgarbaya Khaledgarbaya left a comment

LGTM

Loading

@Khaledgarbaya Khaledgarbaya merged commit b681e91 into axios:master Aug 20, 2018
1 check passed
Loading
@cruelbob
Copy link

@cruelbob cruelbob commented Aug 20, 2018

thx

Loading

@thomasdom
Copy link

@thomasdom thomasdom commented Dec 20, 2018

Will this enhancement be available in 0.19 version? It would be very useful!

Loading

@filippoitaliano
Copy link

@filippoitaliano filippoitaliano commented Jun 10, 2019

Is this isAxiosError property mentioned somewhere in the docs?

Loading

gilbsgilbs added a commit to gilbsgilbs/axios-mock-adapter that referenced this issue Jul 8, 2019
gilbsgilbs added a commit to gilbsgilbs/axios-mock-adapter that referenced this issue Jul 8, 2019
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants