Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding isAxiosError flag to errors thrown by axios #1419

Merged
merged 4 commits into from
Aug 20, 2018
Merged

Adding isAxiosError flag to errors thrown by axios #1419

merged 4 commits into from
Aug 20, 2018

Conversation

AyushG3112
Copy link
Contributor

@AyushG3112 AyushG3112 commented Mar 15, 2018 •
edited
Loading

Adding a isAxiosError flag in errors thrown by axios.

This PR aims to resolve the issue posed by #1415 while preventing breaking changes.

@AyushG3112 AyushG3112 mentioned this pull request Mar 16, 2018
Closed
@AyushG3112 AyushG3112 mentioned this pull request Apr 9, 2018
Closed
@vladkolotvin
Copy link

@AyushG3112 Can you resolve conflicts?
@axe312ger, @Khaledgarbaya

@axe312ger
Copy link
Contributor

Maybe as well @RikkiGibson and @emilyemorehouse

axe312ger
axe312ger previously approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@axe312ger axe312ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will ease up correct error detection a lot :)

@Khaledgarbaya
Copy link
Collaborator

I resolved the conflict @cruelbob @AyushG3112, overall I agree with this change. I will try to merge asap

axe312ger
axe312ger previously approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@axe312ger axe312ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

Khaledgarbaya
Khaledgarbaya approved these changes Aug 20, 2018
View reviewed changes
Copy link
Collaborator

@Khaledgarbaya Khaledgarbaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khaledgarbaya Khaledgarbaya merged commit b681e91 into axios:master Aug 20, 2018
@vladkolotvin
Copy link

thx

@thomasdom
Copy link

Will this enhancement be available in 0.19 version? It would be very useful!

@filippoitaliano
Copy link

Is this isAxiosError property mentioned somewhere in the docs?

@larlew larlew mentioned this pull request Jun 12, 2019
Closed
gilbsgilbs added a commit to gilbsgilbs/axios-mock-adapter that referenced this pull request Jul 8, 2019
@gilbsgilbs
Set isAxiosError property on errors.
2e9eb29 
See axios/axios#1419
@gilbsgilbs gilbsgilbs mentioned this pull request Jul 8, 2019
Merged
gilbsgilbs added a commit to gilbsgilbs/axios-mock-adapter that referenced this pull request Jul 8, 2019
@gilbsgilbs
Set isAxiosError property on errors.
a52ff20 
See axios/axios#1419
This was referenced Aug 13, 2019
Open
Open
Closed
This was referenced Aug 29, 2019
Closed
Open
Closed
Open
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2019
Open
This was referenced Apr 2, 2020
Open
Open
Open
Open
Closed
Merged
Closed
Open
Closed
Closed
Merged
Merged
Merged
Open
Open
Open
This was referenced Apr 13, 2020
Open
Open
Open
Open
Closed
This was referenced Apr 21, 2020
Open
Open
Open
Open
Open
Open
This was referenced Apr 30, 2020
Open
Open
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Khaledgarbaya Khaledgarbaya Khaledgarbaya approved these changes

@axe312ger axe312ger axe312ger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AyushG3112 @vladkolotvin @axe312ger @Khaledgarbaya @thomasdom @filippoitaliano