Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding isAxiosError flag to errors thrown by axios #1419

Merged
merged 4 commits into from Aug 20, 2018

Conversation

@AyushG3112
Copy link
Contributor

commented Mar 15, 2018

Adding a isAxiosError flag in errors thrown by axios.

This PR aims to resolve the issue posed by #1415 while preventing breaking changes.

@cruelbob

This comment has been minimized.

Copy link

commented Aug 20, 2018

@AyushG3112 Can you resolve conflicts?
@axe312ger, @Khaledgarbaya

@axe312ger

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2018

Maybe as well @RikkiGibson and @emilyemorehouse

@axe312ger
Copy link
Contributor

left a comment

LGTM, this will ease up correct error detection a lot :)

@Khaledgarbaya

This comment has been minimized.

Copy link
Collaborator

commented Aug 20, 2018

I resolved the conflict @cruelbob @AyushG3112, overall I agree with this change. I will try to merge asap

@axe312ger
Copy link
Contributor

left a comment

Still LGTM

@Khaledgarbaya
Copy link
Collaborator

left a comment

LGTM

@Khaledgarbaya Khaledgarbaya merged commit b681e91 into axios:master Aug 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cruelbob

This comment has been minimized.

Copy link

commented Aug 20, 2018

thx

@thomasdom

This comment has been minimized.

Copy link

commented Dec 20, 2018

Will this enhancement be available in 0.19 version? It would be very useful!

@adamkowalczyk adamkowalczyk referenced this pull request Jun 3, 2019
3 of 3 tasks complete
@filippoitaliano

This comment has been minimized.

Copy link

commented Jun 10, 2019

Is this isAxiosError property mentioned somewhere in the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.