Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aya: Correctly set the kernel code version for Ubuntu and Debian kernel #579

Merged

Conversation

marysaka
Copy link
Member

Fix BPF syscall failure related to the kernel code version on Ubuntu and Debian.

@netlify
Copy link

netlify bot commented Apr 17, 2023

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3aeeb81
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/644104d49d399b0008a94230
😎 Deploy Preview https://deploy-preview-579--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@marysaka marysaka force-pushed the fix/ubuntu-debian-kernel-version-code branch 2 times, most recently from 23aeda0 to 4d7453a Compare April 17, 2023 14:41
@marysaka
Copy link
Member Author

Should be ready for review now.

Copy link
Collaborator

@alessandrod alessandrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See unwrap() comments.

"looks good" but I'd appreciate a non-libc rewrite. If you can't be bothered that's fair, we can merge as is and I'll put it on my endless todo list :P

aya/src/sys/mod.rs Outdated Show resolved Hide resolved
aya/src/sys/mod.rs Show resolved Hide resolved
aya/src/sys/mod.rs Outdated Show resolved Hide resolved
Fix BPF syscall failure related to the kernel code version.
@marysaka marysaka force-pushed the fix/ubuntu-debian-kernel-version-code branch 2 times, most recently from cdc2cc9 to 97721af Compare April 19, 2023 13:45
@marysaka
Copy link
Member Author

Add some code to ensure support with kernel after 4.19.229.

Fix BPF syscall failure related to the kernel code version.
@marysaka marysaka force-pushed the fix/ubuntu-debian-kernel-version-code branch from 97721af to 3aeeb81 Compare April 20, 2023 09:24
@alessandrod alessandrod merged commit 1066c6c into aya-rs:main Apr 20, 2023
tamird added a commit that referenced this pull request Jul 11, 2023
This restores and enhances the logic originally added in #579.
@tamird tamird mentioned this pull request Jul 11, 2023
tamird added a commit that referenced this pull request Jul 11, 2023
This restores and enhances the logic originally added in #579.
tamird added a commit that referenced this pull request Jul 11, 2023
This restores and enhances the logic originally added in #579.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants