Remove procfs dependency #643
Conversation
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aya/src/util.rs
Outdated
| } | ||
|
|
||
| /// Returns the kernel version of the currently running kernel. | ||
| pub fn current() -> Result<Self, String> { |
There was a problem hiding this comment.
I think we should return a Box<dyn Error> instead of String here
There was a problem hiding this comment.
Can you help me understand how that's better? Currently aya does not depend on anyhow, so other than using strings I can't propagate context.
There was a problem hiding this comment.
This is now a public API, and returning String as Err is frowned upon (i think there's even a clippy lint for it)
Currently aya does not depend on anyhow, so other than using strings I can't propagate context.
libraries should depend on thiserror, apps on anyhow. You can define a thiserror derived error, give it one variant for each string you're returning now, and type erase it when you return it. The result is the same as using a string (Error implements Display), but it's not a String, gives you a backtrace on nightly if you want one etc
This restores and enhances the logic originally added in #579.
Incorrectly inverted in b611038.
This restores and enhances the logic originally added in #579.